Missing applicationUrl does not inherit dashboard url #1169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-codeflow
BrennanConroy
commented
Dec 1, 2023
|
How do you know it’s working without a test 👀 |
|
I tried to write a test, but it's kinda difficult... how do you get the endpoint info for the app? Users can find it by looking at the logs. |
davidfowl
approved these changes
Dec 2, 2023
|
I think this test would be exposing an end point that dumps config or all env variables. The test would look at the effective config. |
BrennanConroy
added a commit
that referenced
this pull request
Dec 8, 2023
This reverts commit d1753a2.
BrennanConroy
added a commit
that referenced
this pull request
Dec 8, 2023
This reverts commit d1753a2.
BrennanConroy
added a commit
that referenced
this pull request
Dec 8, 2023
This reverts commit d1753a2.
davidfowl
pushed a commit
that referenced
this pull request
Dec 8, 2023
joperezr
pushed a commit
that referenced
this pull request
Dec 8, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #225