Skip to content

Remove vstest special version handling #2257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 6, 2023
Merged

Remove vstest special version handling #2257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
258cf6f
Remove vstest special version handling
MichaelSimons Apr 6, 2023
27bbdfb
Remove special testcase for vstest
MichaelSimons Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file modified build.sh
100644 → 100755
View file
Open in desktop
Empty file.
6 changes: 0 additions & 6 deletions src/Microsoft.DotNet.Darc/src/DarcLib/Helpers/VersionFiles.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,6 @@ public static (string BuildId, string ReleaseLabel) DeriveBuildInfo(string repoN

if (releaseParts.Length == 3)
{
// VSTest uses full dates for the first part of their preview build numbers
if (repoName.Contains("vstest"))
{
return ($"{releaseParts[1]}.{releaseParts[2]}", releaseParts[0]);
}

if (int.TryParse(releaseParts[1], out int datePart) && int.TryParse(releaseParts[2], out int buildPart))
{
if (datePart > 1 && datePart < 8 && buildPart > 1000 && buildPart < 10000)
Expand Down
7 changes: 0 additions & 7 deletions src/Microsoft.DotNet.Darc/tests/Microsoft.DotNet.DarcLib.Tests/Helpers/VersionFileTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,13 +32,6 @@ public void OldPreviewVersionIsDerivedTest()
.Should().Be((DateTime.Now.ToString("20220413.1"), "beta"));
}

[Test]
public void VsTestVersionIsDerivedTest()
{
VersionFiles.DeriveBuildInfo("vstest", "17.4.0-preview-20220813-01")
.Should().Be((DateTime.Now.ToString("20220813.01"), "preview"));
}

[Test]
public void NewPreviewVersionIsDerivedTest()
{
Expand Down