Skip to content

[NUnitLite] fix many warnings #9959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src-ThirdParty/NUnitLite/Api/ExpectedExceptionData.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
// ***********************************************************************

using System;
using System.Diagnostics.CodeAnalysis;
using System.Reflection;

namespace NUnit.Framework.Api
Expand Down Expand Up @@ -123,7 +124,9 @@ public string HandlerName
/// </summary>
/// <param name="fixtureType">The Type of the fixture.</param>
/// <returns>A MethodInfo.</returns>
public MethodInfo GetExceptionHandler(Type fixtureType)
public MethodInfo GetExceptionHandler (
[DynamicallyAccessedMembers (DynamicallyAccessedMemberTypes.PublicMethods | DynamicallyAccessedMemberTypes.NonPublicMethods)]
Type fixtureType)
{
if (exceptionHandler == null && handlerName != null)
{
Expand Down
12 changes: 0 additions & 12 deletions src-ThirdParty/NUnitLite/AssertionHelper.cs
Original file line number Diff line number Diff line change
Expand Up @@ -350,17 +350,5 @@ static public void Expect<T>(T actual, IResolveConstraint expression, string mes
#endif

#endregion

#region Map
/// <summary>
/// Returns a ListMapper based on a collection.
/// </summary>
/// <param name="original">The original collection</param>
/// <returns></returns>
public ListMapper Map( ICollection original )
{
return new ListMapper( original );
}
#endregion
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
// ***********************************************************************

using System;
using System.Diagnostics.CodeAnalysis;
using System.Collections;

namespace NUnit.Framework.Constraints
Expand Down Expand Up @@ -358,6 +359,8 @@ public UniqueItemsConstraint Unique
/// </summary>
public XmlSerializableConstraint XmlSerializable
{
[RequiresUnreferencedCode ("Uses XmlSerializer")]
[RequiresDynamicCode ("Uses XmlSerializer")]
get { return (XmlSerializableConstraint)this.Append(new XmlSerializableConstraint()); }
}
#endif
Expand Down
3 changes: 3 additions & 0 deletions src-ThirdParty/NUnitLite/Constraints/ConstraintFactory.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
// ***********************************************************************

using System;
using System.Diagnostics.CodeAnalysis;
using System.Collections;

namespace NUnit.Framework.Constraints
Expand Down Expand Up @@ -305,6 +306,8 @@ public UniqueItemsConstraint Unique
/// </summary>
public XmlSerializableConstraint XmlSerializable
{
[RequiresUnreferencedCode ("Uses XmlSerializer")]
[RequiresDynamicCode ("Uses XmlSerializer")]
get { return new XmlSerializableConstraint(); }
}
#endif
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@

#if !SILVERLIGHT
using System;
using System.Diagnostics.CodeAnalysis;
using System.IO;
using System.Xml;
using System.Xml.Serialization;
Expand All @@ -33,6 +34,8 @@ namespace NUnit.Framework.Constraints
/// XmlSerializableConstraint tests whether
/// an object is serializable in XML format.
/// </summary>
[RequiresUnreferencedCode ("Uses XmlSerializer")]
[RequiresDynamicCode ("Uses XmlSerializer")]
public class XmlSerializableConstraint : Constraint
{
private XmlSerializer serializer;
Expand Down
3 changes: 3 additions & 0 deletions src-ThirdParty/NUnitLite/Is.cs
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
// ***********************************************************************

using System;
using System.Diagnostics.CodeAnalysis;
using System.Collections;
using NUnit.Framework.Constraints;

Expand Down Expand Up @@ -165,6 +166,8 @@ public static UniqueItemsConstraint Unique
/// </summary>
public static XmlSerializableConstraint XmlSerializable
{
[RequiresUnreferencedCode ("Uses XmlSerializer")]
[RequiresDynamicCode ("Uses XmlSerializer")]
get { return new XmlSerializableConstraint(); }
}
#endif
Expand Down
69 changes: 0 additions & 69 deletions src-ThirdParty/NUnitLite/ListMapper.cs

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@
CS1591: Missing XML comment for publicly visible type or member 'Foo'
-->
<NoWarn>1570;1572;1591;CA1305</NoWarn>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
<GenerateAssemblyCompanyAttribute>false</GenerateAssemblyCompanyAttribute>
<GenerateAssemblyConfigurationAttribute>false</GenerateAssemblyConfigurationAttribute>
<GenerateAssemblyProductAttribute>false</GenerateAssemblyProductAttribute>
<GenerateAssemblyTitleAttribute>false</GenerateAssemblyTitleAttribute>
<GenerateAssemblyVersionAttribute>false</GenerateAssemblyVersionAttribute>
<GenerateAssemblyFileVersionAttribute>false</GenerateAssemblyFileVersionAttribute>
</PropertyGroup>

<PropertyGroup>
Expand Down
Loading