[Mono.Android-Tests] Ignore temporary HTTP errors in async test methods. #9942
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the never-ending saga of trying to ignore temporary HTTP errors in
Mono.Android-Tests
test methods, our latest attempt usesAssert.Ignore
. Behind the scenes,Assert.Ignore
breaks out of a test by throwingNUnit.Framework.IgnoreException
. However our very dated test runner doesn't seem to handle this exception properly when in anasync
Task
test method, resulting in this test failure:For the 2
async Task
tests we have, instead check if the HTTP status code indicates we should ignore the test, and if so, just exit the test early. It will show up as "Passed" instead of "Ignored", which isn't perfect, but better than "Failed".