[NUnitLite] don't use System.Reflection in async tests
#9904
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current NUnit implementation can result in failures under
NativeAOT:
Mono.Android.NET_Tests, Xamarin.Android.NetTests.AndroidMessageHandlerNegotiateAuthenticationTests.RequestWithCredentialsSucceeds / Release
System.NullReferenceException : Arg_NullReferenceException
at NUnit.Framework.Internal.AsyncInvocationRegion.AsyncTaskInvocationRegion.WaitForPendingOperationsToComplete(Object) + 0x60
at NUnit.Framework.Internal.Commands.TestMethodCommand.RunAsyncTestMethod(TestExecutionContext) + 0x45
The original code in NUnitLite uses System.Reflection, because it
needed to run in very limited contexts like Silverlight, portable
class libraries, etc.
To solve this, let's just stop using System.Reflection, and just do:
if (invocationResult is Task task)
{
task.Wait();
}
Or in another case:
if (exception is AggregateException ae)
return ae.InnerExceptions;
NUnitLite also called the `Result` property on any `Task<T>`. I simply
removed this functionality, as we have no tests using this feature.
dellis1972
approved these changes
Mar 10, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current NUnit implementation can result in failures under NativeAOT:
The original code in NUnitLite uses System.Reflection, because it needed to run in very limited contexts like Silverlight, portable class libraries, etc.
To solve this, let's just stop using System.Reflection, and just do:
Or in another case:
NUnitLite also called the
Resultproperty on anyTask<T>. I simply removed this functionality, as we have no tests using this feature.