Add a Unit Test for MamJsonParser and upgrade it to use System.Text.Json #9797
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanpeppers
approved these changes
Feb 18, 2025
Co-authored-by: Jonathan Peppers <[email protected]>
Context: f6f11a5a797cd8602854942dccb0f2b1db57c473
Context: https://github.com/dotnet/android/issues/9229
Commit f6f11a5a added support for type and member remapping, to
assist the InTune team.
The `MamJsonParser` type added in f6f11a5a uses Newtonsoft.Json, and
is one of very few uses of Newtonsoft.Json.
Update `MamJsonParser` to use System.Text.Json, so that we can
eventually remove the Newtonsoft.Json dependency from our installs.
Additionally, add a unit test (shock!) for the `<MamJsonToXml/>` task.
The input `mam.json` test JSON data comes from the
`content/MonoAndroid10/remapping-config.json` file within the
[`microsoft.intune.mam.remapper.tasks` NuGet package][0], while
`mam.xml` is the expected output from `tools/remap-mam-json-to-xml`.
Co-authored-by: Jonathan Peppers <[email protected]>
[0]: https://www.nuget.org/packages/Microsoft.Intune.MAM.Remapper.Tasks/0.1.4635.1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context #9229
This is part of our code modernisation effort. In this case the effort to replace Newtonsoft.Json usage throughout the codebase with System.Text.Json.