[Xamarin.Android.Build.Tasks] Java.Interop has typemaps #9768

jonpryor · 2025-02-07T19:36:06Z

If you have a Debug build of .NET for Android, and you enable assembly logging:

% adb shell setprop debug.mono.log default,assembly

then adb logcat will contain messages such as:

I monodroid-assembly: typemap: unable to find mapping to a Java type from managed type 'Java.Interop.ManagedPeer, Java.Interop'
W monodroid: typemap: failed to map managed type to Java type: Java.Interop.ManagedPeer, Java.Interop, Version=10.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065 (Module ID
W monodroid-assembly: typemap: called from
W monodroid-assembly: at Android.Runtime.JNIEnv.TypemapManagedToJava(Type type)
W monodroid-assembly:    at Android.Runtime.AndroidTypeManager.GetSimpleReference(Type type)
W monodroid-assembly:    at Java.Interop.JniRuntime.JniTypeManager.GetTypeSignature(Type type)
W monodroid-assembly:    at Java.Interop.JniPeerMembers..ctor(String jniPeerTypeName, Type managedPeerType, Boolean checkManagedPeerType, Boolean isInterface)
W monodroid-assembly:    at Java.Interop.JniPeerMembers..ctor(String jniPeerTypeName, Type managedPeerType)
W monodroid-assembly:    at Java.Interop.ManagedPeer..cctor()
W monodroid-assembly:    at Java.Interop.JniRuntime..ctor(CreationOptions options)
W monodroid-assembly:    at Android.Runtime.AndroidRuntime..ctor(IntPtr jnienv, IntPtr vm, IntPtr classLoader, IntPtr classLoader_loadClass, Boolean jniAddNativeMethodRegistrationAttributePresent)
W monodroid-assembly:    at Android.Runtime.JNIEnvInit.Initialize(JnienvInitializeArgs* args)
…
I monodroid-assembly: typemap: unable to find mapping to a Java type from managed type 'Java.Interop.JavaObject, Java.Interop'
W monodroid: typemap: failed to map managed type to Java type: Java.Interop.JavaObject, Java.Interop, Version=10.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065 (Module ID: 90427bf1-700a-4676-b23a-fb68e2e2e9da; Type token: 33554439)
W monodroid-assembly: typemap: called from
W monodroid-assembly: at Android.Runtime.JNIEnv.TypemapManagedToJava(Type type)
W monodroid-assembly:    at Android.Runtime.AndroidTypeManager.GetSimpleReference(Type type)
W monodroid-assembly:    at Java.Interop.JniRuntime.JniTypeManager.GetTypeSignature(Type type)
W monodroid-assembly:    at Java.Interop.JniPeerMembers..ctor(String jniPeerTypeName, Type managedPeerType, Boolean checkManagedPeerType, Boolean isInterface)
W monodroid-assembly:    at Java.Interop.JniPeerMembers..ctor(String jniPeerTypeName, Type managedPeerType)
W monodroid-assembly:    at Java.Interop.JavaObject..cctor()
W monodroid-assembly:    at Java.Interop.TypeManager.Activate(IntPtr jobject, ConstructorInfo cinfo, Object[] parms)
W monodroid-assembly:    at Java.Interop.TypeManager.n_Activate(IntPtr jnienv, IntPtr jclass, IntPtr typename_ptr, IntPtr signature_ptr, IntPtr jobject, IntPtr parameters_ptr)
W monodroid-assembly:    at Android.Runtime.JNINativeWrapper.Wrap_JniMarshal_PPLLLL_V(_JniMarshal_PPLLLL_V callback, IntPtr jnienv, IntPtr klazz, IntPtr p0, IntPtr p1, IntPtr p2, IntPtr p3)

ManagedPeer and JavaObject are types within Java.Interop.dll which uses JniPeerMembers, and Debug builds of JniPeerMembers try to verify that the typemap entry is consistent:

partial class JniPeerMembers {
  JniPeerMembers string jniPeerTypeName, Type managedPeerType, bool checkManagedPeerType, bool isInterface = false)
  {
    // …
#if DEBUG
    var signatureFromType   = JniEnvironment.Runtime.TypeManager.GetTypeSignature (managedPeerType);
    if (signatureFromType.SimpleReference != jniPeerTypeName) {
      Debug.WriteLine ("WARNING-Java.Interop: ManagedPeerType <=> JniTypeName Mismatch! javaVM.GetJniTypeInfoForType(typeof({0})).JniTypeName=\"{1}\" != \"{2}\"",
          managedPeerType.FullName,
          signatureFromType.SimpleReference,
          jniPeerTypeName);
      Debug.WriteLine (new System.Diagnostics.StackTrace (true));
    }
#endif  // DEBUG
  }
}

However, Java.Interop.dll is not considered to be a .NET for Android assembly, as it's built with e.g. $(TargetFramework)=net9.0 and not $(TargetFramework)=net9.0-android. As such, it is skipped during typemap processing.

Update XAJavaTypeScanner.SpecialAssemblies so that Java.Interop.dll is explicitly processed. This will ensure that there is a typemap entry for ManagedPeer and that the JniPeerMembers checks pass. This allows typemap entries for JavaObject and ManagedPeer to be created, removing the above warning messages.

If you have a Debug build of .NET for Android, and you enable assembly logging: % adb shell setprop debug.mono.log default,assembly then `adb logcat` will contain messages such as: I monodroid-assembly: typemap: unable to find mapping to a Java type from managed type 'Java.Interop.ManagedPeer, Java.Interop' W monodroid: typemap: failed to map managed type to Java type: Java.Interop.ManagedPeer, Java.Interop, Version=10.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065 (Module ID W monodroid-assembly: typemap: called from W monodroid-assembly: at Android.Runtime.JNIEnv.TypemapManagedToJava(Type type) W monodroid-assembly: at Android.Runtime.AndroidTypeManager.GetSimpleReference(Type type) W monodroid-assembly: at Java.Interop.JniRuntime.JniTypeManager.GetTypeSignature(Type type) W monodroid-assembly: at Java.Interop.JniPeerMembers..ctor(String jniPeerTypeName, Type managedPeerType, Boolean checkManagedPeerType, Boolean isInterface) W monodroid-assembly: at Java.Interop.JniPeerMembers..ctor(String jniPeerTypeName, Type managedPeerType) W monodroid-assembly: at Java.Interop.ManagedPeer..cctor() W monodroid-assembly: at Java.Interop.JniRuntime..ctor(CreationOptions options) W monodroid-assembly: at Android.Runtime.AndroidRuntime..ctor(IntPtr jnienv, IntPtr vm, IntPtr classLoader, IntPtr classLoader_loadClass, Boolean jniAddNativeMethodRegistrationAttributePresent) W monodroid-assembly: at Android.Runtime.JNIEnvInit.Initialize(JnienvInitializeArgs* args) … I monodroid-assembly: typemap: unable to find mapping to a Java type from managed type 'Java.Interop.JavaObject, Java.Interop' W monodroid: typemap: failed to map managed type to Java type: Java.Interop.JavaObject, Java.Interop, Version=10.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065 (Module ID: 90427bf1-700a-4676-b23a-fb68e2e2e9da; Type token: 33554439) W monodroid-assembly: typemap: called from W monodroid-assembly: at Android.Runtime.JNIEnv.TypemapManagedToJava(Type type) W monodroid-assembly: at Android.Runtime.AndroidTypeManager.GetSimpleReference(Type type) W monodroid-assembly: at Java.Interop.JniRuntime.JniTypeManager.GetTypeSignature(Type type) W monodroid-assembly: at Java.Interop.JniPeerMembers..ctor(String jniPeerTypeName, Type managedPeerType, Boolean checkManagedPeerType, Boolean isInterface) W monodroid-assembly: at Java.Interop.JniPeerMembers..ctor(String jniPeerTypeName, Type managedPeerType) W monodroid-assembly: at Java.Interop.JavaObject..cctor() W monodroid-assembly: at Java.Interop.TypeManager.Activate(IntPtr jobject, ConstructorInfo cinfo, Object[] parms) W monodroid-assembly: at Java.Interop.TypeManager.n_Activate(IntPtr jnienv, IntPtr jclass, IntPtr typename_ptr, IntPtr signature_ptr, IntPtr jobject, IntPtr parameters_ptr) W monodroid-assembly: at Android.Runtime.JNINativeWrapper.Wrap_JniMarshal_PPLLLL_V(_JniMarshal_PPLLLL_V callback, IntPtr jnienv, IntPtr klazz, IntPtr p0, IntPtr p1, IntPtr p2, IntPtr p3) `ManagedPeer` and `JavaObject` are types within `Java.Interop.dll` which uses `JniPeerMembers`, and [Debug builds of `JniPeerMembers`][0] try to verify that the typemap entry is consistent: partial class JniPeerMembers { JniPeerMembers string jniPeerTypeName, Type managedPeerType, bool checkManagedPeerType, bool isInterface = false) { // … #if DEBUG var signatureFromType = JniEnvironment.Runtime.TypeManager.GetTypeSignature (managedPeerType); if (signatureFromType.SimpleReference != jniPeerTypeName) { Debug.WriteLine ("WARNING-Java.Interop: ManagedPeerType <=> JniTypeName Mismatch! javaVM.GetJniTypeInfoForType(typeof({0})).JniTypeName=\"{1}\" != \"{2}\"", managedPeerType.FullName, signatureFromType.SimpleReference, jniPeerTypeName); Debug.WriteLine (new System.Diagnostics.StackTrace (true)); } #endif // DEBUG } } However, `Java.Interop.dll` is not considered to be a .NET for Android assembly, as it's built with e.g. `$(TargetFramework)=net9.0` and not `$(TargetFramework)=net9.0-android`. As such, it is skipped during typemap processing. Update `XAJavaTypeScanner.SpecialAssemblies` so that `Java.Interop.dll` is explicitly processed. This will ensure that there is a typemap entry for `ManagedPeer` and that the `JniPeerMembers` checks pass. This allows typemap entries for `JavaObject` and `ManagedPeer` to be created, removing the above warning messages. [0]: https://github.com/dotnet/java-interop/blob/6bc87e8b55bc00ae1423a5ae92cf5db573fc76ed/src/Java.Interop/Java.Interop/JniPeerMembers.cs#L45-L54

dellis1972

Makes sense.
Odd this hasn't caused any problems before?

Context: dotnet/android#9768 dotnet/android#9768 attempts to add types from `Java.Interop.dll` to the .NET for Android typemaps, in order to fix Debug warnings like: I monodroid-assembly: typemap: unable to find mapping to a Java type from managed type 'Java.Interop.ManagedPeer, Java.Interop' Unfortunately, this causes the assertion: AssertGetJniTypeInfoForType (typeof (JavaArray<JavaObject>), "[Ljava/lang/Object;", false, 1); within `Java.InteropTests.JniTypeManagerTests.GetTypeSignature_Type()` to fail: Expected string length 19 but was 33. Strings differ at index 0. Expected: "[Ljava/lang/Object;" But was: "crc64d5d92128469ae06d/JavaArray_1" -----------^ The immediate cause of the failure is that `JniRuntime.JniTypeManager.GetTypeSignature()` called `JniRuntime.JniTypeManager.GetSimpleReference()` *before* it tried to see if the type was `JavaArray<T>`. As `Java.Interop.dll` was now being processed for typemap purposes, and because `JavaArray<T>` did not have a `[JniTypeSignatureAttribute]`, the typemap got the default behavior of `crc64[hash…]`. The broader cause is that `GetSimpleReference()` should be the *fallback* implementation, used after all other attempts to get a JNI name have failed. Update `GetTypeSignature()` and `GetTypeSignatures()` so that `GetSimpleReference()` and/or `GetSimpleReferences()` are in fact treated as fallbacks. Additionally, update `AssertGetJniTypeInfoForType()` to assert that the value returned by `GetTypeSignature()` is the same as the value return3ed by` GetTypeSignatures().First()`. This was *commented* as being the case, but we should *verify* that as well. Finally, update `AssertGetJniTypeInfoForType()` so that when the assertion fails, the source `type` value is provided.

Does It Build™?

Context: dotnet/java-interop@baf43b0 Support for MD5 was removed in dotnet/java-interop@baf43b09. Attempting to use it now results in an XAGJS7015 error: …\Xamarin.Android.Common.targets(1504,3): error XAGJS7015: System.NotSupportedException: PackageNamingPolicy.LowercaseHash is no longer supported. [D:\a\_work\1\a\TestRelease\02-10_20.56.48\temp\PackageNamingPolicyLowercaseMD5\UnnamedProject.csproj] …\Xamarin.Android.Common.targets(1504,3): error XAGJS7015: at Java.Interop.Tools.TypeNameMappings.JavaNativeTypeManager.GetPackageName(TypeDefinition type, IMetadataResolver resolver) in /Users/builder/azdo/_work/3/s/xamarin-android/external/Java.Interop/src/Java.Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.cs:line 683 [D:\a\_work\1\a\TestRelease\02-10_20.56.48\temp\PackageNamingPolicyLowercaseMD5\UnnamedProject.csproj] …\Xamarin.Android.Common.targets(1504,3): error XAGJS7015: at Java.Interop.Tools.TypeNameMappings.JavaNativeTypeManager.<>c__DisplayClass56_0.<ToJniName>b__2(TypeDefinition t) in /Users/builder/azdo/_work/3/s/xamarin-android/external/Java.Interop/src/Java.Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.cs:line 552 [D:\a\_work\1\a\TestRelease\02-10_20.56.48\temp\PackageNamingPolicyLowercaseMD5\UnnamedProject.csproj] …\Xamarin.Android.Common.targets(1504,3): error XAGJS7015: at Java.Interop.Tools.TypeNameMappings.JavaNativeTypeManager.ToJniName[T](T type, Func`2 decl, Func`2 name, Func`2 ns, Func`2 overrideName, Func`2 shouldUpdateName) in /Users/builder/azdo/_work/3/s/xamarin-android/external/Java.Interop/src/Java.Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.cs:line 720 [D:\a\_work\1\a\TestRelease\02-10_20.56.48\temp\PackageNamingPolicyLowercaseMD5\UnnamedProject.csproj] …\Xamarin.Android.Common.targets(1504,3): error XAGJS7015: at Java.Interop.Tools.TypeNameMappings.JavaNativeTypeManager.ToJniName(TypeDefinition type, ExportParameterKind exportKind, IMetadataResolver cache) in /Users/builder/azdo/_work/3/s/xamarin-android/external/Java.Interop/src/Java.Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.cs:line 548 [D:\a\_work\1\a\TestRelease\02-10_20.56.48\temp\PackageNamingPolicyLowercaseMD5\UnnamedProject.csproj] …\Xamarin.Android.Common.targets(1504,3): error XAGJS7015: at Java.Interop.Tools.TypeNameMappings.JavaNativeTypeManager.ToJniName(TypeDefinition type, IMetadataResolver resolver) in /Users/builder/azdo/_work/3/s/xamarin-android/external/Java.Interop/src/Java.Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.cs:line 527 [D:\a\_work\1\a\TestRelease\02-10_20.56.48\temp\PackageNamingPolicyLowercaseMD5\UnnamedProject.csproj] …\Xamarin.Android.Common.targets(1504,3): error XAGJS7015: at Java.Interop.Tools.TypeNameMappings.JavaNativeTypeManager.ToJniName(TypeDefinition type, TypeDefinitionCache cache) in /Users/builder/azdo/_work/3/s/xamarin-android/external/Java.Interop/src/Java.Interop.Tools.TypeNameMappings/Java.Interop.Tools.TypeNameMappings/JavaNativeTypeManager.cs:line 523 [D:\a\_work\1\a\TestRelease\02-10_20.56.48\temp\PackageNamingPolicyLowercaseMD5\UnnamedProject.csproj] …\Xamarin.Android.Common.targets(1504,3): error XAGJS7015: at Xamarin.Android.Tasks.TypeMapGenerator.GetDebugEntry(TypeDefinition td, TypeDefinitionCache cache) in /Users/builder/azdo/_work/3/s/xamarin-android/src/Xamarin.Android.Build.Tasks/Utilities/TypeMapGenerator.cs:line 345 [D:\a\_work\1\a\TestRelease\02-10_20.56.48\temp\PackageNamingPolicyLowercaseMD5\UnnamedProject.csproj] …\Xamarin.Android.Common.targets(1504,3): error XAGJS7015: at Xamarin.Android.Tasks.TypeMapGenerator.GenerateDebugNativeAssembly(Boolean skipJniAddNativeMethodRegistrationAttributeScan, String outputDirectory) in /Users/builder/azdo/_work/3/s/xamarin-android/src/Xamarin.Android.Build.Tasks/Utilities/TypeMapGenerator.cs:line 266 [D:\a\_work\1\a\TestRelease\02-10_20.56.48\temp\PackageNamingPolicyLowercaseMD5\UnnamedProject.csproj] …\Xamarin.Android.Common.targets(1504,3): error XAGJS7015: at Xamarin.Android.Tasks.TypeMapGenerator.GenerateDebug(Boolean skipJniAddNativeMethodRegistrationAttributeScan, String outputDirectory, Boolean generateNativeAssembly) in /Users/builder/azdo/_work/3/s/xamarin-android/src/Xamarin.Android.Build.Tasks/Utilities/TypeMapGenerator.cs:line 179 [D:\a\_work\1\a\TestRelease\02-10_20.56.48\temp\PackageNamingPolicyLowercaseMD5\UnnamedProject.csproj] …\Xamarin.Android.Common.targets(1504,3): error XAGJS7015: at Xamarin.Android.Tasks.TypeMapGenerator.Generate(Boolean debugBuild, Boolean skipJniAddNativeMethodRegistrationAttributeScan, String outputDirectory, Boolean generateNativeAssembly) in /Users/builder/azdo/_work/3/s/xamarin-android/src/Xamarin.Android.Build.Tasks/Utilities/TypeMapGenerator.cs:line 170 [D:\a\_work\1\a\TestRelease\02-10_20.56.48\temp\PackageNamingPolicyLowercaseMD5\UnnamedProject.csproj] …\Xamarin.Android.Common.targets(1504,3): error XAGJS7015: at Xamarin.Android.Tasks.GenerateJavaStubs.WriteTypeMappings(NativeCodeGenState state) in /Users/builder/azdo/_work/3/s/xamarin-android/src/Xamarin.Android.Build.Tasks/Tasks/GenerateJavaStubs.cs:line 466 [D:\a\_work\1\a\TestRelease\02-10_20.56.48\temp\PackageNamingPolicyLowercaseMD5\UnnamedProject.csproj] …\Xamarin.Android.Common.targets(1504,3): error XAGJS7015: at Xamarin.Android.Tasks.GenerateJavaStubs.Run(Boolean useMarshalMethods) in /Users/builder/azdo/_work/3/s/xamarin-android/src/Xamarin.Android.Build.Tasks/Tasks/GenerateJavaStubs.cs:line 269 [D:\a\_work\1\a\TestRelease\02-10_20.56.48\temp\PackageNamingPolicyLowercaseMD5\UnnamedProject.csproj] …\Xamarin.Android.Common.targets(1504,3): error XAGJS7015: at Xamarin.Android.Tasks.GenerateJavaStubs.RunTask() in /Users/builder/azdo/_work/3/s/xamarin-android/src/Xamarin.Android.Build.Tasks/Tasks/GenerateJavaStubs.cs:line 112 [D:\a\_work\1\a\TestRelease\02-10_20.56.48\temp\PackageNamingPolicyLowercaseMD5\UnnamedProject.csproj] …\Xamarin.Android.Common.targets(1504,3): error XAGJS7015: at Microsoft.Android.Build.Tasks.AndroidTask.Execute() in /Users/builder/azdo/_work/3/s/xamarin-android/external/xamarin-android-tools/src/Microsoft.Android.Build.BaseTasks/AndroidTask.cs:line 25 [D:\a\_work\1\a\TestRelease\02-10_20.56.48\temp\PackageNamingPolicyLowercaseMD5\UnnamedProject.csproj] The only reason this hasn't failed before is because `Mono.Android.dll` is special-cased, so the PackageNamingPolicy value is ignored… until we start processing `Java.Interop.dll`! Remove `LowercaseMD5` from `BuildTest.PackageNamingPolicy()` and move it into a new `PackageNamingPolicy_LowercaseMD5_IsObsolete()` test which asserts that the build fails.

New typemaps, new file sizes.

jonpryor · 2025-02-10T22:31:33Z

/azp run

azure-pipelines · 2025-02-10T22:32:01Z

Azure Pipelines successfully started running 1 pipeline(s).

`PackageNamingPolicy_LowercaseMD5_IsObsolete()` was failing because `$(AndroidManifest)` was set. Bad copy & paste! Fix: JNI ERROR (app bug): accessed stale Local 0xd1 (index 13 in a table of size 13) within `FromNative()`.

jonpryor · 2025-02-11T11:42:20Z

/azp run

azure-pipelines · 2025-02-11T11:42:58Z

Azure Pipelines successfully started running 1 pipeline(s).

Context: 25d1f00 THE STORY SO FAR Remember 25d1f00? > With a partially heavy heart, we need to special-case typemap entries > by processing `Mono.Android.dll` *first*, so that it gets first dibs > at bindings for `java/lang/Object` and other types. > > … > > Note that the special-casing needs to happen in `NativeTypeMappingData` > because typemaps were formerly processed in *sorted module order*, in > which the sort order is based on the *byte representation* of the > module's MVID (a GUID). Additionally, *linking changes the MVID*, > which means module order is *effectively random*. Consequently, > trying to special case typemap ordering anywhere else is ineffective. The above is only true for *Release* builds. *Debug* builds don't go through `NativeTypeMappingData`, and have a different mechanism and format for typemap data. Update `XAJavaTypeScanner.GetJavaTypes()` to process `Mono.Android.dll` *before* any other assemblies, ensuring that `java/lang/Object` is typemap'd to `Java.Lang.Object, Mono.Android.dll`. Add a new `ObjectTest.java_lang_Object_Is_Java_Lang_Object()` unit test which explicitly verifies the mapping for `java/lang/Object`.

The test doesn't fail now! …because, due to "special-casing" so that Mono.Android.dll is processed first -- and probably the `[JniTypeSignature]` additions in java-interop? -- we don't trigger the exception codepath now. ¯\_(ツ)_/¯

jonpryor · 2025-02-11T21:08:32Z

Draft commit message:

Bump to dotnet/java-interop/main@d62008d1 (#9768)

Changes: https://github.com/dotnet/java-interop/compare/57f7bc849f36ec7c3159cc7729c7276b8dcd3ca4...d62008d1ad7f469f801c7c00613f3a9fc94648a1

  * dotnet/java-interop@d62008d1: [Java.Interop] GetSimpleReferences(): fallback for GetTypeSignatures() (dotnet/java-interop#1305)

Context: 25d1f007a7bd1ca3ce960315fabd04b9a687224e

If you have a Debug build of .NET for Android, and you enable
assembly logging:

	% adb shell setprop debug.mono.log default,assembly

then `adb logcat` will contain messages such as:

	I monodroid-assembly: typemap: unable to find mapping to a Java type from managed type 'Java.Interop.ManagedPeer, Java.Interop'
	W monodroid: typemap: failed to map managed type to Java type: Java.Interop.ManagedPeer, Java.Interop, Version=10.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065 (Module ID
	W monodroid-assembly: typemap: called from
	W monodroid-assembly: at Android.Runtime.JNIEnv.TypemapManagedToJava(Type type)
	W monodroid-assembly:    at Android.Runtime.AndroidTypeManager.GetSimpleReference(Type type)
	W monodroid-assembly:    at Java.Interop.JniRuntime.JniTypeManager.GetTypeSignature(Type type)
	W monodroid-assembly:    at Java.Interop.JniPeerMembers..ctor(String jniPeerTypeName, Type managedPeerType, Boolean checkManagedPeerType, Boolean isInterface)
	W monodroid-assembly:    at Java.Interop.JniPeerMembers..ctor(String jniPeerTypeName, Type managedPeerType)
	W monodroid-assembly:    at Java.Interop.ManagedPeer..cctor()
	W monodroid-assembly:    at Java.Interop.JniRuntime..ctor(CreationOptions options)
	W monodroid-assembly:    at Android.Runtime.AndroidRuntime..ctor(IntPtr jnienv, IntPtr vm, IntPtr classLoader, IntPtr classLoader_loadClass, Boolean jniAddNativeMethodRegistrationAttributePresent)
	W monodroid-assembly:    at Android.Runtime.JNIEnvInit.Initialize(JnienvInitializeArgs* args)
	…
	I monodroid-assembly: typemap: unable to find mapping to a Java type from managed type 'Java.Interop.JavaObject, Java.Interop'
	W monodroid: typemap: failed to map managed type to Java type: Java.Interop.JavaObject, Java.Interop, Version=10.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065 (Module ID: 90427bf1-700a-4676-b23a-fb68e2e2e9da; Type token: 33554439)
	W monodroid-assembly: typemap: called from
	W monodroid-assembly: at Android.Runtime.JNIEnv.TypemapManagedToJava(Type type)
	W monodroid-assembly:    at Android.Runtime.AndroidTypeManager.GetSimpleReference(Type type)
	W monodroid-assembly:    at Java.Interop.JniRuntime.JniTypeManager.GetTypeSignature(Type type)
	W monodroid-assembly:    at Java.Interop.JniPeerMembers..ctor(String jniPeerTypeName, Type managedPeerType, Boolean checkManagedPeerType, Boolean isInterface)
	W monodroid-assembly:    at Java.Interop.JniPeerMembers..ctor(String jniPeerTypeName, Type managedPeerType)
	W monodroid-assembly:    at Java.Interop.JavaObject..cctor()
	W monodroid-assembly:    at Java.Interop.TypeManager.Activate(IntPtr jobject, ConstructorInfo cinfo, Object[] parms)
	W monodroid-assembly:    at Java.Interop.TypeManager.n_Activate(IntPtr jnienv, IntPtr jclass, IntPtr typename_ptr, IntPtr signature_ptr, IntPtr jobject, IntPtr parameters_ptr)
	W monodroid-assembly:    at Android.Runtime.JNINativeWrapper.Wrap_JniMarshal_PPLLLL_V(_JniMarshal_PPLLLL_V callback, IntPtr jnienv, IntPtr klazz, IntPtr p0, IntPtr p1, IntPtr p2, IntPtr p3)

`ManagedPeer` and `JavaObject` are types within `Java.Interop.dll`
which uses `JniPeerMembers`, and [Debug builds of `JniPeerMembers`][0]
try to verify that the typemap entry is consistent:

	partial class JniPeerMembers {
	  JniPeerMembers string jniPeerTypeName, Type managedPeerType, bool checkManagedPeerType, bool isInterface = false)
	  {
	    // …
	#if DEBUG
	    var signatureFromType   = JniEnvironment.Runtime.TypeManager.GetTypeSignature (managedPeerType);
	    if (signatureFromType.SimpleReference != jniPeerTypeName) {
	      Debug.WriteLine ("WARNING-Java.Interop: ManagedPeerType <=> JniTypeName Mismatch! javaVM.GetJniTypeInfoForType(typeof({0})).JniTypeName=\"{1}\" != \"{2}\"",
	          managedPeerType.FullName,
	          signatureFromType.SimpleReference,
	          jniPeerTypeName);
	      Debug.WriteLine (new System.Diagnostics.StackTrace (true));
	    }
	#endif  // DEBUG
	  }
	}

However, `Java.Interop.dll` is not considered to be a .NET for Android
assembly, as it's built with e.g. `$(TargetFramework)=net9.0` and not
`$(TargetFramework)=net9.0-android`.  As such, it is skipped during
typemap processing.

Update `XAJavaTypeScanner.SpecialAssemblies` so that `Java.Interop.dll`
is explicitly processed.  This will ensure that there is a typemap
entry for `ManagedPeer` and that the `JniPeerMembers` checks pass.
This allows typemap entries for `JavaObject` and `ManagedPeer` to be
created, removing the above warning messages.

This also requires updating `XAJavaTypeScanner.GetJavaTypes()` so
that in Debug builds, `Mono.Android.dll` is processed *before* any
other assemblies, ensuring that `java/lang/Object` is typemap'd to
`Java.Lang.Object, Mono.Android.dll`.  See also 25d1f007, which did
the same thing for *Release* builds.

Add a new `ObjectTest.java_lang_Object_Is_Java_Lang_Object()` unit
test which explicitly verifies the mapping for `java/lang/Object`.

[0]: https://github.com/dotnet/java-interop/blob/6bc87e8b55bc00ae1423a5ae92cf5db573fc76ed/src/Java.Interop/Java.Interop/JniPeerMembers.cs#L45-L54

#1305) Context: dotnet/android#9768 dotnet/android#9768 attempts to add types from `Java.Interop.dll` to the .NET for Android typemaps, in order to fix Debug warnings like: I monodroid-assembly: typemap: unable to find mapping to a Java type from managed type 'Java.Interop.ManagedPeer, Java.Interop' Unfortunately, the initial attempt to generate typemaps for `Java.Interop.dll` caused the assertion: AssertGetJniTypeInfoForType (typeof (JavaArray<JavaObject>), "[Ljava/lang/Object;", false, 1); within `Java.InteropTests.JniTypeManagerTests.GetTypeSignature_Type()` to fail with: Expected string length 19 but was 33. Strings differ at index 0. Expected: "[Ljava/lang/Object;" But was: "crc64d5d92128469ae06d/JavaArray_1" -----------^ The immediate cause of the failure is that `JniRuntime.JniTypeManager.GetTypeSignature()` called `JniRuntime.JniTypeManager.GetSimpleReference()` *before* it tried to see if the type was `JavaArray<T>`. As `Java.Interop.dll` was now being processed for typemap purposes, and because `JavaArray<T>` did not have a `[JniTypeSignatureAttribute]`, the typemap got the default behavior of `crc64[hash…]`. The broader cause is that `GetSimpleReference()` should be the *fallback* implementation, used after all other attempts to get a JNI name have failed. Update `GetTypeSignature()` and `GetTypeSignatures()` so that `GetSimpleReference()` and/or `GetSimpleReferences()` are in fact treated as fallbacks. Additionally, update `AssertGetJniTypeInfoForType()` to assert that the value returned by `GetTypeSignature()` is the same as the value return3ed by` GetTypeSignatures().First()`. This was *commented* as being the case, but we should *verify* that as well. Finally, *move* the `type.GetCustomAttribute<JniTypeSignatureAttribute()` and `GetReplacementType()` logic into `GetSimpleReferences()`. This This emphasizes the "fallback" nature of `GetSimpleReference()`, adds an missing `GetReplacementType()` invocation from the `GetTypeSignatures()` codepath, and this is what [`AndroidTypeManager.GetSimpleReference()`][0] was already doing. [0]: https://github.com/dotnet/android/blob/21c413195e300b6440eb437dade4f3a114e795f7/src/Mono.Android/Android.Runtime/AndroidRuntime.cs#L279-L289

…terop.dll-has-typemaps

jonpryor · 2025-02-12T02:10:18Z

/azp run

azure-pipelines · 2025-02-12T02:10:47Z

Azure Pipelines successfully started running 1 pipeline(s).

jonpryor · 2025-02-12T13:19:51Z

Fully green here: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=10997525&view=results

Not sure how two separate PR builds were started for this…

* main: Bump to dotnet/java-interop@d62008d1 (#9768)

jonpryor requested review from dellis1972 and jonathanpeppers as code owners February 7, 2025 19:36

dellis1972 approved these changes Feb 7, 2025

View reviewed changes

jonathanpeppers approved these changes Feb 7, 2025

View reviewed changes

jonpryor mentioned this pull request Feb 10, 2025

[Java.Interop] GetSimpleReferences():fallback for GetTypeSignatures() dotnet/java-interop#1305

Merged

jonpryor added 4 commits February 10, 2025 15:29

Try dotnet/java-interop#1305

59ead6a

Does It Build™?

Update apkdesc file.

7d7a2b4

New typemaps, new file sizes.

Try to figure out an InvalidCastException

81fd46c

Fixity Fix?

be68bee

`PackageNamingPolicy_LowercaseMD5_IsObsolete()` was failing because `$(AndroidManifest)` was set. Bad copy & paste! Fix: JNI ERROR (app bug): accessed stale Local 0xd1 (index 13 in a table of size 13) within `FromNative()`.

jonpryor added 3 commits February 11, 2025 14:46

FLushity Flush

8e74770

jonpryor added 2 commits February 11, 2025 20:27

dotnet/java-interop#1305 is merged! bump to main!

753f04c

Merge remote-tracking branch 'origin/main' into dev/jonp/jonp-Java.In…

842e7d0

…terop.dll-has-typemaps

dellis1972 approved these changes Feb 12, 2025

View reviewed changes

Remove debug print statement in ObjectTest.cs

74ad703

jonpryor merged commit 7acf328 into main Feb 12, 2025
1 of 21 checks passed

jonpryor deleted the dev/jonp/jonp-Java.Interop.dll-has-typemaps branch February 12, 2025 13:22

jonpryor mentioned this pull request Feb 12, 2025

Bump external/Java.Interop from 57f7bc8 to d62008d #9783

Closed

grendello added a commit that referenced this pull request Feb 12, 2025

Merge branch 'main' into dev/grendel/clr-host

4db4159

* main: Bump to dotnet/java-interop@d62008d1 (#9768)

github-actions bot locked and limited conversation to collaborators Mar 15, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Xamarin.Android.Build.Tasks] Java.Interop has typemaps #9768

[Xamarin.Android.Build.Tasks] Java.Interop has typemaps #9768

Uh oh!

jonpryor commented Feb 7, 2025

Uh oh!

dellis1972 left a comment

Uh oh!

jonpryor commented Feb 10, 2025

Uh oh!

azure-pipelines bot commented Feb 10, 2025

Uh oh!

jonpryor commented Feb 11, 2025

Uh oh!

azure-pipelines bot commented Feb 11, 2025

Uh oh!

jonpryor commented Feb 11, 2025 •

edited

Loading

Uh oh!

jonpryor commented Feb 12, 2025

Uh oh!

azure-pipelines bot commented Feb 12, 2025

Uh oh!

jonpryor commented Feb 12, 2025

Uh oh!

Uh oh!

Uh oh!

[Xamarin.Android.Build.Tasks] Java.Interop has typemaps #9768

[Xamarin.Android.Build.Tasks] Java.Interop has typemaps #9768

Uh oh!

Conversation

jonpryor commented Feb 7, 2025

Uh oh!

dellis1972 left a comment

Choose a reason for hiding this comment

Uh oh!

jonpryor commented Feb 10, 2025

Uh oh!

azure-pipelines bot commented Feb 10, 2025

Uh oh!

jonpryor commented Feb 11, 2025

Uh oh!

azure-pipelines bot commented Feb 11, 2025

Uh oh!

jonpryor commented Feb 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jonpryor commented Feb 12, 2025

Uh oh!

azure-pipelines bot commented Feb 12, 2025

Uh oh!

jonpryor commented Feb 12, 2025

Uh oh!

Uh oh!

Uh oh!

jonpryor commented Feb 11, 2025 •

edited

Loading