[NativeAOT] Integrate TryCreatePeer #9746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dbb0b92 Context: dotnet/java-interop@dd3c1d0 Commit dbb0b92 had to copy significant parts of `JniRuntime.JniValueManager.CreatePeer()` in order to get the desired semantics. dotnet/java-interop@dd3c1d05 added a `TryCreatePeer()` virtual method in an effort to reduce the amount of copied code required. Update `NativeAotValueManager` to override the new method, allowing us to remove most of the `CreatePeer()` code added in dbb0b92. Additionally, override `GetInvokerTypeCOre()` within `NativeAotTypeManager` so that .NET for Android -style `Invoker` types can be appropriately resolved.
grendello
added a commit
that referenced
this pull request
Feb 4, 2025
* main: [NativeAOT] Integrate TryCreatePeer (#9746) Bump to dotnet/java-interop@dd3c1d05 (#9745)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dbb0b92
Context: dotnet/java-interop@dd3c1d0
Commit dbb0b92 had to copy significant parts of
JniRuntime.JniValueManager.CreatePeer()in order to get the desired semantics. dotnet/java-interop@dd3c1d05 added aTryCreatePeer()virtual method in an effort to reduce the amount of copied code required.Update
NativeAotValueManagerto override the new method, allowing us to remove most of theCreatePeer()code added in dbb0b92. Additionally, overrideGetInvokerTypeCOre()withinNativeAotTypeManagerso that .NET for Android -styleInvokertypes can be appropriately resolved.