Skip to content

[Mono.Android] Remove usages of JNINativeWrapper.CreateDelegate. #9741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2025

Conversation

jpobst
Copy link
Contributor

@jpobst jpobst commented Jan 31, 2025

Context: dotnet/java-interop#1275

Throughout the years of binding Mono.Android there have been instances where we need to write manual binding code to work around issues in generator. These instances need to be manually updated to mirror the latest generator output by removing calls to JNINativeWrapper.CreateDelegate that would prevent NativeAOT from functioning.

It is recommended to review this PR with "Hide Whitespace Changes", as adding try/catch blocks affected indentation.

@jpobst jpobst force-pushed the dev/jpobst/create-delegate branch from f90133a to 7dab6c9 Compare February 11, 2025 18:59
@jpobst jpobst marked this pull request as ready for review February 13, 2025 21:16
@jpobst jpobst requested a review from jonpryor as a code owner February 13, 2025 21:16
@jonpryor jonpryor merged commit 5a89eae into main Feb 24, 2025
58 checks passed
@jonpryor jonpryor deleted the dev/jpobst/create-delegate branch February 24, 2025 20:44
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants