[Xamarin.Android.Build.Tasks] fix NRT warnings & other warnings #9483
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduces the setting to `Xamarin.Android.Build.Tasks.csproj`:
<WarningsAsErrors>Nullable</WarningsAsErrors>
Then I fixed the existing warnings. Down the road this will make it
easier to adopt `#enable nullable`, and eventually `Nullable=enable`
the entire project. Trying to do that now results in 1,000+ warnings...
Most of these are types that could easily be null, and they weren't
marked as nullable with `?`. Luckily, the code appears to be checking
for null in these places already.
jonathanpeppers
commented
Nov 4, 2024
src/Xamarin.Android.NamingCustomAttributes/Android.App/ServiceAttribute.cs
Outdated
Show resolved
Hide resolved
|
As a further future step, we should also multitarget to |
jpobst
reviewed
Nov 19, 2024
src/Xamarin.Android.NamingCustomAttributes/Android.App/ActivityAttribute.cs
Outdated
Show resolved
Hide resolved
maybe upgrading to netstandard2.1 might be better? |
dellis1972
reviewed
Nov 19, 2024
dellis1972
approved these changes
Nov 19, 2024
|
The two test failures we can ignore:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the setting to
Xamarin.Android.Build.Tasks.csproj:Then I fixed the existing warnings. Down the road this will make it easier to adopt
#enable nullable, and eventuallyNullable=enablethe entire project. Trying to do that now results in 1,000+ warnings...Most of these are types that could easily be null, and they weren't marked as nullable with
?. Luckily, the code appears to be checking for null in these places already.