Skip to content

Support Visual Studio "Build Acceleration" #9042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 26, 2024
Merged

Support Visual Studio "Build Acceleration" #9042

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
70cb8a5
Support Visual Studio "Build Acceleration"
dellis1972 Jun 19, 2024
e6648fb
fix spelling
dellis1972 Jun 19, 2024
44d98d4
fix formatting
dellis1972 Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions ...rin.Android.Build.Tasks/MSBuild/Xamarin/Android/Xamarin.Android.Resource.Designer.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,6 +196,28 @@ Copyright (C) 2016 Xamarin. All rights reserved.
</ItemGroup>
</Target>

<!--
The Visual Studio FastUpdate check flags the Resource Designer assembly as
newer than the output assembly (which it is). But it causes it to incorrectly
think the build is out of date.

So lets remove it. We MUST remove the item from the @ReferencePathWithRefAssemblies
ItemGroup BEFORE the CollectResolvedCompilationReferencesDesignTime target runs.
This is because that target uses the Returns functionality. It turns out you cannot
modify the ItemGroup that is being returned via a Returns on a target.
-->
<Target Name="_RemoveResourceDesignerFromResolvedComilationReferences"
BeforeTargets="CollectResolvedCompilationReferencesDesignTime"
Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'android'"
>
<ItemGroup>
<_ResourceDesignerFiles Include="%(ReferencePathWithRefAssemblies.Identity)"
Condition="'%(ReferencePathWithRefAssemblies.OriginalPath)' == '$(_GenerateResourceDesignerAssemblyOutput)'"
/>
<ReferencePathWithRefAssemblies Remove="@(_ResourceDesignerFiles)" />
</ItemGroup>
</Target>

<Target Name="_BuildResourceDesigner"
Condition=" '$(AndroidUseDesignerAssembly)' == 'True' "
DependsOnTargets="$(_BuildResourceDesignerDependsOn)" />
Expand Down