[build] set $(AllowSelfContainedWithoutRuntimeIdentifier)
#8547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: #8366 Context: dotnet/sdk@d21e6bf Rolf introduced an "escape hatch" in the .NET 9 SDK for emitting a build warning for a case that doesn't make sense on mobile. All mobile apps are self-contained, and we define RIDs by default, so the error is not needed. It appears than when building `net8.0-android` apps on the .NET 9 SDK, we will also need to silence this warning. This property should not have any effect in the stable, .NET 8 SDK. After this change goes in, we'll likely need the .NET 9 Android workload to depend on a newer .NET 8 Android workload with this change in place.
pjcollins
approved these changes
Nov 30, 2023
jonathanpeppers
deleted the
AllowSelfContainedWithoutRuntimeIdentifier
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #8366
Context: dotnet/sdk@d21e6bf
Rolf introduced an "escape hatch" in the .NET 9 SDK for emitting a build warning for a case that doesn't make sense on mobile. All mobile apps are self-contained, and we define RIDs by default, so the error is not needed.
It appears than when building
net8.0-androidapps on the .NET 9 SDK, we will also need to silence this warning. This property should not have any effect in the stable, .NET 8 SDK.After this change goes in, we'll likely need the .NET 9 Android workload to depend on a newer .NET 8 Android workload with this change in place.