[Xamarin.Android.Build.Tasks] allow two different r-classes.jar files #5691
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#5627 In some cases, Android Studio projects can produce `.aar` files that contain: libs/r-classes.jar Reviewing the contents of one of these `r-classes.jar` files: com/test/R.class It appears they are potentially moving any `R.java` files into this new `r-classes.jar` file. So if you have two `.aar` files that contain a `r-classes.jar` in a Xamarin.Android application, you would currently run into the error: JAR library references with identical file names but different contents were found: r-classes.jar. Please remove any conflicting libraries from EmbeddedJar, InputJar and AndroidJavaLibrary. We should make the `<CheckDuplicateJavaLibraries/>` MSBuild task ignore this issue for `r-classes.jar`. I can't find any good links to explain this new file, or why it exists. I added a test for this scenario.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5627
In some cases, Android Studio projects can produce
.aarfiles thatcontain:
Reviewing the contents of one of these
r-classes.jarfiles:It appears they are potentially moving any
R.javafiles into thisnew
r-classes.jarfile.So if you have two
.aarfiles that contain ar-classes.jarin aXamarin.Android application, you would currently run into the error:
We should make the
<CheckDuplicateJavaLibraries/>MSBuild taskignore this issue for
r-classes.jar. I can't find any good links toexplain this new file, or why it exists.
I added a test for this scenario.