[Xamarin.Android.Build.Tasks] Add Support for AndroidManifest.xml overlays #5325
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rlays Fixes dotnet#5312 The manifest merger tool supports providing additional AndroidManifest.xml files which will `overlay` on top of the final file. This commit adds a new Build Action `AndroidManifestOverlay` which can be used to provide these files to the manifest merger. Users can now use these overlay files to alter the manifest during build time. This can be for adding new permissions or even removing ones that are not needed. It will also allow for different manifest files to be generated for debug/release configurations. This can be done by conditionally including `overlay` files depending on the `$(Configuration)`. ``` <ItemGroup> <AndroidManifestOverlay Include="DebugPermissions.xml" Condition=" '$(Configuration)' == 'Debug' " /> </ItemGroup> ```
dellis1972
requested review from
jonathanpeppers and
jonpryor
as code owners
radekdoulik
reviewed
Nov 23, 2020
radekdoulik
approved these changes
Nov 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5312
The manifest merger tool supports providing additional AndroidManifest.xml
files which will
overlayon top of the final file. This commit adds anew Build Action
AndroidManifestOverlaywhich can be used to providethese files to the manifest merger.
Users can now use these overlay files to alter the manifest during
build time. This can be for adding new permissions or even removing
ones that are not needed. It will also allow for different manifest
files to be generated for debug/release configurations. This can be
done by conditionally including
overlayfiles depending on the$(Configuration).