Provide warnings around compileSdkVersion(TargetFrameworkVersion), targetSdkVersion, and minSdkVersion #2050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
build |
|
build |
|
Review pending clarifications on the original issue. |
|
The failure here is |
dellis1972
force-pushed
the
Issue1768
branch
from
16281fb to
cccecca
Compare
dellis1972
force-pushed
the
Issue1768
branch
from
b8e71cb to
7147d6b
Compare
dellis1972
force-pushed
the
Issue1768
branch
5 times, most recently
from
7cbad1c to
a2e568d
Compare
dellis1972
force-pushed
the
Issue1768
branch
4 times, most recently
from
b5dc5c5 to
11f21a2
Compare
dellis1972
changed the title
|
@jonpryor @JonDouglas any thoughts on the PR? Did we decide what we are doing ? |
…on, targetSdkVersion, and minSdkVersion Context dotnet#1768 Google has the following guidance for these three values: > minSdkVersion (lowest possible) <= targetSdkVersion == compileSdkVersion (latest SDK) This commit adds a new Task `CheckGoogleSdkRequirements` which is responsible for checking these values. It will be enabled by default but the task can be disabled via the `AndroidEnableGooglePlayStoreChecks` property.
dellis1972
force-pushed
the
Issue1768
branch
from
d4bacc1 to
9066b5e
Compare
Current guesstimate is that this will land in XA 9.4, not 9.2.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context #1768
Google has the following guidance for these three values:
This commit adds a new Task
CheckGoogleSdkRequirementswhich is responsible for checkingthese values. It will be enabled by default but the task can be disabled via the
AndroidEnableGooglePlayStoreChecksproperty.