[Build.Tasks] Modernize MSBuild Task Properties with Nullable Reference Types #10278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR systematically modernizes MSBuild task properties in
src/Xamarin.Android.Build.Tasks/Tasks/
to follow the repository's nullable reference types guidelines as outlined in.github/copilot-instructions.md
.Changes Made
Updated 4 MSBuild task files from
#nullable disable
to#nullable enable
with proper nullable annotations:string.IsNullOrEmpty()
calls to extension method patternPattern Updates Applied
Required Properties: Added default values
Non-Required Properties: Made nullable
Output Properties: Made nullable since they are set during execution
String Checks: Converted to extension method pattern
Scope
This addresses part of the broader modernization effort across 145 task files:
#nullable disable
to#nullable enable
#nullable disable
to convertTesting
All updated files compile successfully without nullable reference type warnings or errors. The changes preserve existing functionality while improving type safety.
Addressing #10277.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/svg-android/svg-android.jar
/home/REDACTED/work/android/android/bin/Debug/dotnet/dotnet exec --runtimeconfig /home/REDACTED/work/android/android/bin/TestDebug/net9.0/Xamarin.Android.Build.Tests.runtimeconfig.json --depsfile /home/REDACTED/work/android/android/bin/TestDebug/net9.0/Xamarin.Android.Build.Tests.deps.json /home/REDACTED/work/android/android/bin/TestDebug/net9.0/testhost.dll --port 45059 --endpoint 127.0.0.1:045059 --role client --parentprocessid 51727 --telemetryoptedin false
(http block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.