[xabt] enable R2R Composite by default for CoreCLR in Release #10245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: #10007 Just like we enable `$(RunAOTCompilation)` and `$(AndroidEnableProfiledAot)` in `Release` mode by default for Mono, we should enable R2R composite for CoreCLR. "One weird trick" we're doing is to set `$(_IsPublishing)` by default, so the correct packs can be restored & ran during a `dotnet build`. We were already doing this for NativeAOT, so hoping the same trick will work for CoreCLR. I also updated the `BasicApplicationPublishReadyToRun()` test to verify these defaults are working as expected.
jonathanpeppers
commented
Jun 24, 2025
...id.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.DefaultProperties.targets
Show resolved
Hide resolved
Context: https://github.com/dotnet/sdk/blob/2488777341b8691e07272b576126a8fe62b0911f/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.RuntimeIdentifierInference.targets#L228C135-L230 This error is meant to show for platforms that do not support `$(RuntimeIdentifiers)` plural.
jonathanpeppers
commented
Jun 27, 2025
| <PublishReadyToRun Condition=" '$(PublishReadyToRun)' == '' and '$(Configuration)' == 'Release' ">true</PublishReadyToRun> | ||
| <PublishReadyToRunComposite Condition=" '$(PublishReadyToRunComposite)' == '' and '$(PublishReadyToRun)' == 'true' ">true</PublishReadyToRunComposite> | ||
| <_IsPublishing Condition=" '$(_IsPublishing)' == '' and '$(PublishReadyToRun)' == 'true' ">true</_IsPublishing> | ||
| <AllowReadyToRunWithoutRuntimeIdentifier Condition=" '$(PublishReadyToRun)' == 'true' and '$(RuntimeIdentifiers)' != '' ">true</AllowReadyToRunWithoutRuntimeIdentifier> |
There was a problem hiding this comment.
Note that this is required for multi-RID builds:
(_CheckForUnsupportedAppHostUsage target) ->
C:\a\_work\1\s\bin\Release\dotnet\sdk\10.0.100-preview.6.25304.106\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.RuntimeIdentifierInference.targets(219,5):
error NETSDK1191: A runtime identifier for the property 'PublishReadyToRun' couldn't be inferred. Specify a rid explicitly.
grendello
approved these changes
Jun 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #10007
Just like we enable
$(RunAOTCompilation)and$(AndroidEnableProfiledAot)inReleasemode by default for Mono, we should enable R2R composite for CoreCLR."One weird trick" we're doing is to set
$(_IsPublishing)by default, so the correct packs can be restored & ran during adotnet build. We were already doing this for NativeAOT, so hoping the same trick will work for CoreCLR.I also updated the
BasicApplicationPublishReadyToRun()test to verify these defaults are working as expected.