Skip to content

Remove $(_AndroidAllowDeltaInstall) feature and related infrastructure #10237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 24, 2025

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jun 23, 2025

This PR removes the $(_AndroidAllowDeltaInstall) MSBuild property and related infrastructure as this feature has been removed from IDEs.

Changes Made

  • Removed property constant: Eliminated _AndroidAllowDeltaInstall from KnownProperties.cs
  • Updated test cases: Modified DebuggingTest.cs to remove the allowDeltaInstall parameter from all test cases and removed one test case that specifically tested the delta install functionality
  • Removed NuGet feed: Eliminated the "xamarin.android util" feed from NuGet.config that was used for the Xamarin.Android.Deploy.Installer package

Files Modified

  • src/Xamarin.Android.Build.Tasks/Tests/Xamarin.ProjectTools/Android/KnownProperties.cs - Removed property constant
  • tests/MSBuildDeviceIntegration/Tests/DebuggingTest.cs - Updated test method signature and test cases
  • NuGet.config - Removed deprecated NuGet feed and related comments

The changes are minimal and surgical, removing only the specific delta install functionality without affecting other features. No PackageReference to Xamarin.Android.Deploy.Installer was found in the codebase, and no related .dll files exist in the repository.

Fixes #10188.


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

@Copilot Copilot AI changed the title [WIP] Remove $(_AndroidAllowDeltaInstall) Remove $(_AndroidAllowDeltaInstall) feature and related infrastructure Jun 23, 2025
@Copilot Copilot AI requested a review from jonathanpeppers June 23, 2025 14:18
Copilot finished work on behalf of jonathanpeppers June 23, 2025 14:18
@jonathanpeppers jonathanpeppers marked this pull request as ready for review June 23, 2025 20:33
@jonathanpeppers jonathanpeppers enabled auto-merge (squash) June 23, 2025 20:37
@jonathanpeppers jonathanpeppers merged commit 0bb6cc3 into main Jun 24, 2025
59 checks passed
@jonathanpeppers jonathanpeppers deleted the copilot/fix-10188 branch June 24, 2025 13:40
@github-actions github-actions bot locked and limited conversation to collaborators Jul 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove $(_AndroidAllowDeltaInstall)
3 participants