[ci] run MSBuild "SmokeTests" category on all runtimes #10085
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For each "smoke test" that build an Android application project (libraries not really relevant), we run the test on all runtimes. For each test, I generally added two more test cases for NativeAOT and CoreCLR. This is a first step to ensure that we don't break CoreCLR or NativeAOT support at build time.
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Android smoke test suite by supporting multiple .NET runtime configurations (MonoVM, CoreCLR, NativeAOT) during MSBuild execution. Key changes include:
- Adding a SetRuntime extension method in ProjectExtensions.cs to set the appropriate runtime property.
- Updating test cases in PackagingTest.cs, BuildTest.cs, BuildTest.TestCaseSource.cs, and AssetPackTests.cs to include a new AndroidRuntime parameter.
- Adjusting build assertions and test logic to correctly handle runtime-specific behaviors and warnings.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ProjectExtensions.cs | Introduces the SetRuntime extension method to configure the project based on the specified AndroidRuntime. |
| PackagingTest.cs | Updates test cases to include an AndroidRuntime parameter and applies the runtime configuration. |
| BuildTest.cs | Extends test methods with an AndroidRuntime parameter and adjusts build logic (e.g. warning assertions and preview feature enablement) accordingly. |
| BuildTest.TestCaseSource.cs | Adds runtime parameter values to the test case sources for improved consistency. |
| AssetPackTests.cs | Revises asset pack tests to accept a runtime parameter and set the runtime on the project. |
Files not reviewed (1)
- src/Xamarin.Android.Build.Tasks/Microsoft.Android.Sdk/targets/Microsoft.Android.Sdk.NativeAOT.targets: Language not supported
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest.cs
Outdated
Show resolved
Hide resolved
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest.cs
Show resolved
Hide resolved
jpobst
approved these changes
Apr 30, 2025
...Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/ProjectExtensions.cs
Show resolved
Hide resolved
pjcollins
approved these changes
Apr 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For each "smoke test" that build an Android application project (libraries not really relevant), we run the test on all runtimes.
For each test, I generally added two more test cases for NativeAOT and CoreCLR.
This is a first step to ensure that we don't break CoreCLR or NativeAOT support at build time.
This also discovered a bug on NativeAOT, in a project with spaces:
The fix was to quote
@(LinkerArg):