Add ChannelDbConnectionPool stub and unit tests. #3396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdaigle
changed the title
mdaigle
force-pushed
the
dev/mdaigle/channel-connection-pool
branch
from
b8a5318 to
8f11e53
Compare
mdaigle
force-pushed
the
dev/mdaigle/channel-connection-pool
branch
2 times, most recently
from
585a12b to
6b59d91
Compare
mdaigle
force-pushed
the
dev/mdaigle/channel-connection-pool
branch
from
6b59d91 to
12c7aa8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3396 +/- ##
==========================================
+ Coverage 64.59% 65.93% +1.34%
==========================================
Files 300 301 +1
Lines 65603 65625 +22
==========================================
+ Hits 42375 43272 +897
+ Misses 23228 22353 -875
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cheenamalhotra
approved these changes
Jun 5, 2025
benrr101
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a class for the new connection pool. Adds unit tests for the class to ensure exceptions are thrown as expected.
Issues
#3356
Testing
Added unit tests.
Guidelines
Please review the contribution guidelines before submitting a pull request: