Skip to content

Conversation

BradBarnich
Copy link
Contributor

a potential fix for #3324

as described in the linked issue, it was intended to be there in the netfx build but was lost in the sdk csproj conversion

I'm not very familiar with resources, but it seems like it should be emitted for both netfx and net core builds.

@cheenamalhotra
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@cheenamalhotra
Copy link
Member

cheenamalhotra commented May 2, 2025

Thanks for finding and addressing the issue @BradBarnich , I agree this is necessary, and believe that must have been an oversight in the commit you attached in the issue.

@cheenamalhotra cheenamalhotra requested a review from a team May 2, 2025 22:42
@cheenamalhotra cheenamalhotra added this to the 6.1-preview2 milestone May 2, 2025
@benrr101 benrr101 merged commit 41a5358 into dotnet:main May 5, 2025
237 checks passed
Copy link

codecov bot commented May 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.20%. Comparing base (965e5ff) to head (1973a13).
Report is 2 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (965e5ff) and HEAD (1973a13). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (965e5ff) HEAD (1973a13)
addons 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3325      +/-   ##
==========================================
- Coverage   67.74%   62.20%   -5.54%     
==========================================
  Files         298      292       -6     
  Lines       65536    65226     -310     
==========================================
- Hits        44397    40574    -3823     
- Misses      21139    24652    +3513     
Flag Coverage Δ
addons ?
netcore 66.57% <ø> (-5.57%) ⬇️
netfx 60.63% <ø> (-5.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants