Merge | Fix/commands null #3310
Conversation
|
@dotnet-policy-service agree company="VTEX" |
|
It looks like a good idea - the change is pretty simple. However, we want to make sure that these get caught by our localization process (and that we have consistent error messaging). Could you put the error message in our /resources/string.resx file and reference that when throwing the exception, please? |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlBatch.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
| { | ||
| get | ||
| { | ||
| return ResourceManager.GetString("ADP_NoSqlBatchCommandList", resourceCulture); |
There was a problem hiding this comment.
Looks real good except ... Either this line should be ADP_NoSqlBatchCommandsList (with an s) OR the resx file should be ADP_NoSqlBatchCommandList (without an s). I personally would vote for the second choice
As it stands right now, the mismatch is causing the unit test to fail due to ArgumentNullException coming from looking up the resx.
There was a problem hiding this comment.
Good catch! Great suggestion. Just fixed.
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
@benrr101 Do you have any clue about tests? It seems the results are not good. =\ |
|
Looks like some network blips. I'm re-running the failed tests. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3310 +/- ##
==========================================
- Coverage 72.94% 0 -72.95%
==========================================
Files 298 0 -298
Lines 57002 0 -57002
==========================================
- Hits 41579 0 -41579
+ Misses 15423 0 -15423
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Currently the method is returning Object reference not set to an instance of an object when we try to run a batch without commands. This PR returns SqlBatchCommand list has not been initialized instead.
I'd appreciate a CI & Test run.