Skip to content

Remove support for .NET Standard 2.0 and 2.1 #2386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 3, 2024

Conversation

ErikEJ
Copy link
Contributor

@ErikEJ ErikEJ commented Mar 5, 2024

fixes #2340

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.05%. Comparing base (c33bde2) to head (470141b).

❗ Current head 470141b differs from pull request most recent head a5c75f5. Consider uploading reports for the commit a5c75f5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2386      +/-   ##
==========================================
- Coverage   72.69%   71.05%   -1.64%     
==========================================
  Files         313      296      -17     
  Lines       61737    60725    -1012     
==========================================
- Hits        44878    43150    -1728     
- Misses      16859    17575     +716     
Flag Coverage Δ
addons 92.88% <ø> (ø)
netcore 73.65% <ø> (-3.38%) ⬇️
netfx 70.12% <ø> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Mar 5, 2024

@JRahnama All net462 builds pass, despite being labelled with netstandard2.1 - but maybe the label is misleading?

@JRahnama
Copy link
Contributor

JRahnama commented Mar 5, 2024

@JRahnama All net462 builds pass, despite being labelled with netstandard2.1 - but maybe the label is misleading?

labels are misleading, I will try to make a test pipeline for this PR today.

Update: failures are all due to building netstandard tests which are expected.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Mar 18, 2024

@JRahnama any progress on the pipeline Update?

@DavoudEshtehari DavoudEshtehari added this to the 6.0-preview1 milestone Mar 26, 2024
@ErikEJ
Copy link
Contributor Author

ErikEJ commented Apr 5, 2024

@David-Engel @JRahnama Is this still on the radar?

@DavoudEshtehari DavoudEshtehari added the Breaking Change 🔨 Issues/PRs that are related with breaking API changes in the driver. label Apr 9, 2024
@DavoudEshtehari
Copy link
Contributor

A new file with .NET Standard support has been added in pull request #2310.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Apr 9, 2024

I will merge with latest main and remove it.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Apr 9, 2024

How is it going with the pipeline update??

@DavoudEshtehari
Copy link
Contributor

We're going to set up a test pipeline to verify the outcome of this change. Once it's merged, we'll replace it with the current CI.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Apr 9, 2024

@DavoudEshtehari sounds great. I will Update tomorrow

@DavoudEshtehari
Copy link
Contributor

You should be able to see this pipeline, which has been setup for your branch.

Copy link
Contributor

@DavoudEshtehari DavoudEshtehari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! In addition to the CI pipeline, we recently pushed a few YAML files for production pipeline into the GitHub repo, and they should be updated and verified internally. We'll prepare the necessary internal changes to ensure that these PRs are merged with the least time gap.

@ErikEJ
Copy link
Contributor Author

ErikEJ commented Apr 11, 2024

@DavoudEshtehari Thanks, let me know if there is anything else I need to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change 🔨 Issues/PRs that are related with breaking API changes in the driver.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for .NET Standard
4 participants