Abort prepare-release command when version on current branch is not incremented #599
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncremented Ensure version on current branch is updated by prepare-release command When the next version for the current branch is set by the user using the '--nextVersion' command line parameter, the next version might be equal to the current version. In that case no commit is created (no changes on the branch), which in turn causes the current branch to be fast-forwarded to the commit on the newly-created release branch when the branches are merged. To prevent this error, abort command if both versions match (there is already a check in place that prevents the version from being decremented). The check only applies to the current branch because the version on the release branch not being incremented is a valid use case.
AArnott
approved these changes
May 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the next version for the current branch is set by the user using the
--nextVersioncommand line parameter, the next version might be equal to the current version.In that case no commit is created (no changes on the branch), which in turn causes the current branch to be fast-forwarded to the commit on the newly-created release branch when the branches are merged.
To prevent this error, abort command if both versions match (there is already a check in place that prevents the version from being decremented).
The check only applies to the current branch because the version on the release branch not being incremented is a valid use case.
This should fix #591