Don't try to disable CA2243 warnings in the generated version info files for F# #1174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Numpsy
changed the title
Smaug123
approved these changes
Feb 15, 2025
This was referenced Mar 21, 2025
Smaug123
added a commit
to G-Research/HeterogeneousCollections
that referenced
this pull request
Mar 21, 2025
This picks up dotnet/Nerdbank.GitVersioning#1174 , allowing us to build without workarounds on 9.0.20x.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #1173
Maybe it'd be easier to just make AddAnalysisSuppressions() a no-op for F# for now, but I thought maybe overriding WarningCodesToSuppress to an empty collection and then handling that case would be more flexible in case it actually does need to supress any other warnings later.