-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Allow override method/property for ParamsSource #2832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+41
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can you add an integration test for that? |
Thank you for checking quickly! |
timcassell
approved these changes
Sep 19, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @neuecc!
1 task
This was referenced Sep 24, 2025
This was referenced Oct 1, 2025
Bump the nsubstitute_benchmarks_minor_patch_updates group with 3 updates
nsubstitute/NSubstitute#910
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when specifying abstract properties or methods with ParamsSource, an exception occurs with SingleOrDefault:
System.InvalidOperationException: Sequence contains more than one matching element
This is because
sourceType.GetAllMethods()
andsourceType.GetAllProperties()
traverse up the parent class hierarchy, enumerating both the overridden property and abstract property with the same name.And since
GetValidValuesForParamsSource
processes withSingleOrDefault
, the exception occurs.Since the enumeration starts from sourceType in order, this should be safe to change to
FirstOrDefault
as the best match.