Test for both .sln and .slnx when searching for solution file #2764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 21, 2025
This was referenced Aug 5, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces enhancements to the
DotNetCliGeneratorclass to improve support for solution file extensions. The changes primarily focus on making the code more extensible and maintainable by centralizing the handling of solution extensions.Enhancements to solution file handling:
src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliGenerator.cs: Added a new static arraySolutionExtensionsto define supported solution file extensions (.slnand.slnx).src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliGenerator.cs: Updated theIsRootSolutionFoldermethod to use the newSolutionExtensionsarray for checking solution file extensions, replacing the hardcoded values.Fixes #2763