-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Blazor file download updates #24560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blazor file download updates #24560
Conversation
|
I will vote for "the URL should be revoked with the API as indicated". This is perfect. |
|
Like most of the PU engineers, Tanay doesn't usually do Random™ 🤣 ... I won't be surprised if he had something specific in mind. |
TanayParikh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @guardrex for putting this together. Left some minor comments:
Co-authored-by: Tanay Parikh <[email protected]>
|
I have some sample code in this repo which received some feedback from @SteveSandersonMS. Mainly after running into some issues with memory out of bounds on large files. See 36872 and 60287 |
|
Thanks @ylr-research ... I yield to @TanayParikh on those. He's a real programmer, not a HackDino™ 🦖 like me! 😄 I haven't even had time to walk through this guidance in detail and experience the code first-hand, as I've been busy 🏃🏃🏃🏃🏃😅 on a number of other article issues. I'll be returning this article later for additional updates, including ...
I've cross-linked your comment to my UE ("User Experience") tracking issue so that I don't forget to check them out later when I circle back to this article. |
Co-authored-by: Tanay Parikh <[email protected]>
Fixes #24521
Thanks @ylr-research! 🚀
❓
For the following remark ...
I'm not keen on the "generally" part without further explanation. What does "generally" mean in this context? I think we should say when/how it might be unsafe ... or strike the "generally" language in favor of just saying that the URL should be revoked with the API as indicated. 👂
cc: @Rick-Anderson @serpent5 FYI: There's an unrelated absolute cross-link to EF Core docs in the RP tutorial that popped up on the build report.
I've added a fix for it on this PR, so you can ignore it if it pops up on other PRs today ...UPDATE (1/13): We're a bit delayed here, so I moved the link fix to #24599 for immediate merge.... to ...