Skip to content

fix(enum-array): support introspection result #751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hjoelh
Copy link
Contributor

@hjoelh hjoelh commented Jun 19, 2024

Description

  • added support to enum-array plugin for introspection result / remote schema
  • added @graphql-codegen/typescript-enum-array to readme list

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

added test cases, also running a local fork at work with the same changes

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Jun 19, 2024

🦋 Changeset detected

Latest commit: e812a76

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/typescript-enum-array Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hjoelh hjoelh marked this pull request as ready for review June 19, 2024 20:49
@saihaj
Copy link
Collaborator

saihaj commented Jun 19, 2024

Can you please add a changeset that will help for automated release changenotes. Learn more

@saihaj
Copy link
Collaborator

saihaj commented Jun 21, 2024

thank you!

@saihaj saihaj merged commit 4547e62 into dotansimha:main Jun 21, 2024
@saihaj
Copy link
Collaborator

saihaj commented Jun 21, 2024

@hjoelh hjoelh deleted the fix(enum-array)-support-introspection-result branch June 24, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants