fix(flutter-freezed): missing comma in enums #72

MitkoTschimev · 2023-01-26T07:08:02Z

Add missing trailing comma for enum values

Before

enum AssetOrder {
  @JsonKey(name: 'contentType_ASC')
  contentTypeAsc
  @JsonKey(name: 'contentType_DESC')
  contentTypeDesc
}

Now

enum AssetOrder {
  @JsonKey(name: 'contentType_ASC')
  contentTypeAsc,
  @JsonKey(name: 'contentType_DESC')
  contentTypeDesc,
}

🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.

Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Related # (issue)

Type of change

Please delete options that are not relevant.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

Screenshots/Sandbox (if appropriate/relevant):

Adding links to sandbox or providing screenshots can help us understand more about this PR and take action on it as appropriate

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A
Test B

Test Environment:

OS:
@graphql-codegen/...:
NodeJS:

Checklist:

I have followed the CONTRIBUTING doc and the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@jsonkey

Add missing trailing comma for enum values Before ```dart enum AssetOrder { @jsonkey(name: 'contentType_ASC') contentTypeAsc @jsonkey(name: 'contentType_DESC') contentTypeDesc } ``` Now ```dart enum AssetOrder { @jsonkey(name: 'contentType_ASC') contentTypeAsc, @jsonkey(name: 'contentType_DESC') contentTypeDesc, } ```

changeset-bot · 2023-01-26T07:08:05Z

🦋 Changeset detected

Latest commit: 9c972ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@graphql-codegen/flutter-freezed	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

saihaj · 2023-01-27T18:28:20Z

@Parables can you check this out?

saihaj

we should add a test for this

Parables · 2023-01-27T18:30:24Z

@MitkoTschimev thanks for trying out this plugin and for the PR. I sincerely appreciate your contribution

To get your PR merged, please complete the following:

Run yarn && yarn test -u to Update the tests. This will update the tests/plugin.spec.ts from line 42 - 144

Parables · 2023-01-27T18:31:31Z

we should add a test for this

@saihaj how can I do that on my end here and push it back into this PR?

saihaj · 2023-01-27T18:34:38Z

we should add a test for this

@saihaj how can I do that on my end here and push it back into this PR?

I think @MitkoTschimev can update tests?

Parables · 2023-01-27T18:38:40Z

@MitkoTschimev thanks for trying out this plugin and for the PR. I sincerely appreciate your contribution

To get your PR merged, please complete the following:

Run yarn && yarn test -u to Update the tests. This will update the tests/plugin.spec.ts from line 42 - 144

@MitkoTschimev, please do this and let's get this fixed as soon as possible.
I don't mean to pressure you but this is a critical issue. It renders this plugin and its output totally useless

MitkoTschimev · 2023-01-27T20:43:44Z

Let me take a look tomorrow to fix the tests

Parables · 2023-02-01T02:09:20Z

@MitkoTschimev, any updates on this?

If it's okay with you, I can fix this and tag you on the PR attributing the fix to you.

MitkoTschimev · 2023-02-01T02:40:11Z

sorry for the late response :( was very busy at business!
I triggered an update of the snapshots now

but let us check how we could improve it.

maybe we can generate a real dart file and trigger the dart linter against it when the tests run. This way we can also cover dart updates in the future if the syntax / common linting rules are changing.

Parables · 2023-02-01T04:11:40Z

@saihaj please can we get this PR merged now

Parables · 2023-02-01T04:14:29Z

@MitkoTschimev I love your suggestion... I will get that done ASAP

saihaj · 2023-02-01T05:23:57Z

@MitkoTschimev can you add a changeset for this? run yarn changeset and then do a patch update for the plugin and explain your changes

MitkoTschimev · 2023-02-01T07:20:03Z

Give me a second ;) just coming back from a nursery event from my son :)

MitkoTschimev · 2023-02-01T07:41:15Z

I never worked with changeset but is this correct what happened?
Changeset created a folder and file. Should I commit this one?

Parables · 2023-02-01T11:16:56Z

@MitkoTschimev you can include the before and after code snippet you used in the issue to add a bit of context about the change

saihaj · 2023-02-01T20:19:09Z

https://github.com/dotansimha/graphql-code-generator-community/releases/tag/release-1675282344073

Parables · 2023-02-02T12:56:17Z

@saihaj please proceed to release this

I will submit another one that addresses some typos and misleading code samples in the guide and the plugin config as well as the live demo

MitkoTschimev mentioned this pull request Jan 26, 2023

flutter-freezed is generating enums with a missing , at the ned of each prop #71

Closed

saihaj reviewed Jan 27, 2023

View reviewed changes

chore(flutter-freezed): update snapshot tests

bdb9982

chore(flutter-freezed): add changelog

9c972ab

saihaj merged commit c70b4ce into dotansimha:main Feb 1, 2023

github-actions bot mentioned this pull request Feb 1, 2023

Upcoming Release Changes #88

Merged

fix(flutter-freezed): missing comma in enums #72

fix(flutter-freezed): missing comma in enums #72

Uh oh!

Conversation

MitkoTschimev commented Jan 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Screenshots/Sandbox (if appropriate/relevant):

How Has This Been Tested?

Checklist:

Further comments

Uh oh!

changeset-bot bot commented Jan 26, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

saihaj commented Jan 27, 2023

Uh oh!

saihaj left a comment

Choose a reason for hiding this comment

Uh oh!

Parables commented Jan 27, 2023

Uh oh!

Parables commented Jan 27, 2023

Uh oh!

saihaj commented Jan 27, 2023

Uh oh!

Parables commented Jan 27, 2023

Uh oh!

MitkoTschimev commented Jan 27, 2023

Uh oh!

Parables commented Feb 1, 2023

Uh oh!

MitkoTschimev commented Feb 1, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Parables commented Feb 1, 2023

Uh oh!

Parables commented Feb 1, 2023

Uh oh!

saihaj commented Feb 1, 2023

Uh oh!

MitkoTschimev commented Feb 1, 2023

Uh oh!

MitkoTschimev commented Feb 1, 2023

Uh oh!

Parables commented Feb 1, 2023

Uh oh!

saihaj commented Feb 1, 2023

Uh oh!

Parables commented Feb 2, 2023

Uh oh!

Uh oh!

MitkoTschimev commented Jan 26, 2023 •

edited

Loading

changeset-bot bot commented Jan 26, 2023 •

edited

Loading

MitkoTschimev commented Feb 1, 2023 •

edited

Loading