feat: add jsdelivr minified versions #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request enhances the functionality of the
client/jsdelivrpackage by adding support for identifying and including minified versions of.jsand.cssfiles. It also introduces corresponding tests to ensure correctness. The changes primarily focus on extending file handling logic and updating the library utilities.Enhancements to file handling:
client/jsdelivr/jsdelivr.go: Added regex patterns to identify.jsand.cssfiles and their minified counterparts (.min.jsand.min.css). Updated thewalkFilesfunction to include minified file paths for.jsand.cssfiles when they are not already present. [1] [2] [3]library/files.go: Introduced theFileNameMinfunction to generate the minified file names for.jsand.cssfiles based on their original names.Test coverage:
client/jsdelivr/jsdelivr_test.go: Added a new test,TestIncludeMinified, to verify that theFetchPackageFilesfunction correctly includes minified file versions for a sample package.