Skip to content

feat: add incremental caching #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

TimothyMakkison
Copy link
Contributor

@TimothyMakkison TimothyMakkison commented Sep 11, 2023

Hey, big fan of your library. It's super intuitive and reminds me of rusts enums, I hope C# has this added one day 😄

Adds incremental caching and benchmarks. Used ImmutableEquatableArray to make UnionDeclaration equtable.

Results

Method Mean Error StdDev Gen0 Gen1 Allocated
Compile 1,074.8 us 21.44 us 27.88 us 195.3125 35.1563 380.21 KB
Cached 556.8 us 4.75 us 3.96 us 48.8281 - 74.99 KB

@domn1995
Copy link
Owner

Thanks for the contribution, and very impressive benchmarks! Will take a closer look after work today :)

Copy link
Owner

@domn1995 domn1995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love these changes! Simpler and more performant 🎉

@domn1995 domn1995 merged commit d85bdeb into domn1995:main Sep 12, 2023
@TimothyMakkison TimothyMakkison deleted the incremental branch September 12, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants