feat: add method that returns all vertices #167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Tomasi <[email protected]>
|
Hi Dominik (nice name!), thanks for you PR! This seems to be a quite sought-after function, I believe #149 also implements this. What's your thoughts on the differences between your two approaches, @jonbrandenburg and @dtomasi? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Dominik,
I would like to add a method to Graph and Store interface that returns all the vertices that have been added. I'm using graph to resolve dependencies and have to loop over all the vertices after all the edges have been set without error. So this would safe me from keeping an extra map or slice with vertices in my project. Let me know if you want me to change anything in this implementation.
Best,
Dominik