Skip to content

Apply analyzer suggestions #3334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

martincostello
Copy link
Collaborator

Apply code analyzer suggestions for various non-test types.

Apply code analyzer suggestions for various types.
Apply code analyzer suggestions for various types.
Apply code analyzer suggestions for various types.
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 88.88889% with 58 lines in your changes missing coverage. Please review.

Project coverage is 84.56%. Comparing base (32463c2) to head (55bbee6).

Files with missing lines Patch % Lines
...DependencyInjection/SwaggerGenOptionsExtensions.cs 51.72% 28 Missing ⚠️
...emaGenerator/JsonSerializerDataContractResolver.cs 66.66% 6 Missing ⚠️
...etCore.Annotations/SwaggerSchemaFilterAttribute.cs 0.00% 3 Missing ⚠️
...aggerGen/SchemaGenerator/SchemaGeneratorOptions.cs 40.00% 3 Missing ⚠️
...AspNetCore.Annotations/SwaggerSubTypesAttribute.cs 0.00% 2 Missing ⚠️
...Core.SwaggerGen/SchemaGenerator/SchemaGenerator.cs 93.10% 2 Missing ⚠️
...rGen/SwaggerGenerator/SwaggerGeneratorException.cs 0.00% 2 Missing ⚠️
...aggerGen/XmlComments/XmlCommentsOperationFilter.cs 81.81% 2 Missing ⚠️
...aggerGen/XmlComments/XmlCommentsParameterFilter.cs 80.00% 2 Missing ⚠️
...pNetCore.Annotations/AnnotationsOperationFilter.cs 94.73% 1 Missing ⚠️
... and 7 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3334      +/-   ##
==========================================
+ Coverage   83.51%   84.56%   +1.04%     
==========================================
  Files          79       84       +5     
  Lines        3216     3227      +11     
  Branches      556      563       +7     
==========================================
+ Hits         2686     2729      +43     
+ Misses        530      498      -32     
Flag Coverage Δ
Linux 84.56% <88.88%> (+1.04%) ⬆️
Windows 83.29% <88.88%> (-0.23%) ⬇️
macOS 83.29% <88.88%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello marked this pull request as ready for review March 22, 2025 18:06
@martincostello martincostello merged commit 84944a0 into domaindrivendev:master Mar 22, 2025
9 checks passed
@martincostello martincostello deleted the code-modernisation branch March 22, 2025 18:06
This was referenced Jul 29, 2025
This was referenced Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants