Skip to content

Fix DescribeAllParametersInCamelCase usage in GenerateOpenApiOperationFromMetadataAsync #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

maksim-sovkov
Copy link
Contributor

Pull Request

The issue or feature being addressed

Fixes #3271

Details on the issue fix or feature implementation

The correct parameter name was generated in the GenerateParameterAndContext method, but was not used further.

Added assignment of a new parameter name to the GenerateOpenApiOperationFromMetadataAsync method.
Added a unit test.

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.56%. Comparing base (1bd9324) to head (ba13fd3).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3309   +/-   ##
=======================================
  Coverage   83.56%   83.56%           
=======================================
  Files          76       76           
  Lines        3224     3225    +1     
  Branches      559      559           
=======================================
+ Hits         2694     2695    +1     
  Misses        530      530           
Flag Coverage Δ
Linux 83.56% <100.00%> (+<0.01%) ⬆️
Windows 83.56% <100.00%> (+<0.01%) ⬆️
macOS 83.56% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello added this to the v7.3.2 milestone Mar 18, 2025
@martincostello
Copy link
Collaborator

Thanks!

@martincostello martincostello merged commit c29e9c2 into domaindrivendev:master Mar 18, 2025
9 checks passed
@maksim-sovkov maksim-sovkov deleted the metadataCase branch March 18, 2025 10:00
This was referenced Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: GenerateOpenApiOperationFromMetadataAsync Does not respect DescribeAllParametersInCamelCase
3 participants