Skip to content

.NET 10 preparation #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 18, 2025
Merged

.NET 10 preparation #3285

merged 7 commits into from
Mar 18, 2025

Conversation

martincostello
Copy link
Collaborator

@martincostello martincostello commented Mar 3, 2025

Cherry-pick refactoring from #3283 to make multi-targeting easier for ASP.NET Core 10 and Microsoft.OpenApi v2.

This PR will be easiest to review one commit at a time, as the second commit effectively just renames all the non-TFM'd snapshots to one of the TFMs, then the other files are just copies of the those with the name of the other TFM.

Cherry-pick refactoring from #3283 to make multi-targeting easier for ASP.NET Core 10 and Microsoft.OpenApi v2.
@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 70.45455% with 13 lines in your changes missing coverage. Please review.

Project coverage is 83.56%. Comparing base (1d7aed0) to head (76f789d).

Files with missing lines Patch % Lines
...re.SwaggerGen/SwaggerGenerator/SwaggerGenerator.cs 68.75% 5 Missing ⚠️
...ggerGen/SchemaGenerator/OpenApiSchemaExtensions.cs 55.55% 4 Missing ⚠️
...Core.SwaggerGen/SchemaGenerator/SchemaGenerator.cs 83.33% 2 Missing ⚠️
...pNetCore.Annotations/AnnotationsOperationFilter.cs 0.00% 1 Missing ⚠️
...e.SwaggerGen/SwaggerGenerator/OpenApiAnyFactory.cs 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3285      +/-   ##
==========================================
- Coverage   86.08%   83.56%   -2.53%     
==========================================
  Files          79       77       -2     
  Lines        3378     3224     -154     
  Branches      588      559      -29     
==========================================
- Hits         2908     2694     -214     
- Misses        470      530      +60     
Flag Coverage Δ
Linux 83.56% <70.45%> (ø)
Windows 83.56% <70.45%> (+45.32%) ⬆️
macOS 83.56% <70.45%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Make Verify snapshots unique per target framework.
This is to when .NET 10 introduces OpenAPI 3.1, it doesn't cause issues with the snapshots being intentionally different.
Apply IDE suggestion to use collection expressions.
Shorten test names to avoid `MAX_PATH` issues on Windows in GitHub Actions.
@martincostello martincostello marked this pull request as ready for review March 3, 2025 16:39
@martincostello martincostello mentioned this pull request Mar 3, 2025
12 tasks
Bump coverlet, Microsoft.NET.Test.Sdk, ReportGenerator, and xunit to their latest stable versions.
- Update more NuGet package version overrides for tests to the latest versions.
- Drop leftover `net6.0` reference in tests.
@martincostello martincostello merged commit ecbb87f into master Mar 18, 2025
9 checks passed
@martincostello martincostello deleted the dotnet-10-prep branch March 18, 2025 13:41
This was referenced Jul 29, 2025
This was referenced Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants