Skip to content

Conversation

@ozziepeeps
Copy link
Contributor

Pull Request

The issue or feature being addressed

Fix JsonSerializerDataContractResolver so that it handles square arrays correctly
Fixes #3244

@codecov-commenter
Copy link

codecov-commenter commented Feb 3, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.57%. Comparing base (2826dd9) to head (290229e).

Files with missing lines Patch % Lines
...emaGenerator/JsonSerializerDataContractResolver.cs 33.33% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3245      +/-   ##
==========================================
- Coverage   83.62%   83.57%   -0.05%     
==========================================
  Files          76       76              
  Lines        3182     3185       +3     
  Branches      538      539       +1     
==========================================
+ Hits         2661     2662       +1     
- Misses        521      523       +2     
Flag Coverage Δ
Linux 83.57% <33.33%> (-0.05%) ⬇️
Windows 83.57% <33.33%> (-0.05%) ⬇️
macOS 83.57% <33.33%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ozziepeeps
Copy link
Contributor Author

@martincostello hopefully this is a quick review for you! TIA!

@martincostello martincostello added this to the v7.2.1 milestone Feb 4, 2025
Copy link
Collaborator

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martincostello martincostello merged commit 1aa7f09 into domaindrivendev:master Feb 4, 2025
9 checks passed
@ozziepeeps ozziepeeps deleted the mosborn/bug/3244 branch February 4, 2025 16:33
This was referenced Jul 31, 2025
This was referenced Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: JsonSerializerDataContractResolver cannot handle square arrays, but NewtonsoftDataContractResolver can

3 participants