Skip to content

Humanize multi line code tag #3239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

EvgeniyZ
Copy link
Contributor

@EvgeniyZ EvgeniyZ commented Jan 29, 2025

The issue or feature being addressed

Resolves #3069

Details on the issue fix or feature implementation

for some reason swagger ui <pre><code> is cutting first line from code block

<code>this content is cutted
{
   "Id": 1
}
</code>

here's how GetAll looks like

image

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.62%. Comparing base (5ecbb3b) to head (b3bfdba).

Files with missing lines Patch % Lines
...re.SwaggerGen/XmlComments/XmlCommentsTextHelper.cs 84.21% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3239      +/-   ##
==========================================
- Coverage   84.83%   83.62%   -1.21%     
==========================================
  Files          76       76              
  Lines        3165     3182      +17     
  Branches      536      538       +2     
==========================================
- Hits         2685     2661      -24     
- Misses        480      521      +41     
Flag Coverage Δ
Linux 83.62% <84.21%> (+15.12%) ⬆️
Windows 83.62% <84.21%> (+0.02%) ⬆️
macOS 83.62% <84.21%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@martincostello martincostello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martincostello martincostello added this to the v7.2.1 milestone Jan 29, 2025
@martincostello martincostello merged commit 2826dd9 into domaindrivendev:master Jan 29, 2025
9 checks passed
This was referenced Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Put <details> into remarks with <code>, the display of content is looks strange
3 participants