-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Humanize multi line code tag #3239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Humanize multi line code tag #3239
Conversation
trim text at the end and add newline if text containing `<code>\r\n` and/or `\r\n</code>` combinations. (cherry picked from commit 53a8e8a)
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3239 +/- ##
==========================================
- Coverage 84.83% 83.62% -1.21%
==========================================
Files 76 76
Lines 3165 3182 +17
Branches 536 538 +2
==========================================
- Hits 2685 2661 -24
- Misses 480 521 +41
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
test/Swashbuckle.AspNetCore.SwaggerGen.Test/XmlComments/XmlCommentsTextHelperTests.cs
Outdated
Show resolved
Hide resolved
src/Swashbuckle.AspNetCore.SwaggerGen/XmlComments/XmlCommentsTextHelper.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The issue or feature being addressed
Resolves #3069
Details on the issue fix or feature implementation
for some reason swagger ui
<pre><code>
is cutting first line from code blockhere's how
GetAll
looks like