Skip to content

Conversation

martincostello
Copy link
Collaborator

@martincostello martincostello commented Jan 12, 2025

Tested it unblocks #3217 manually.

- Add overload to `OpenApiAnyFactory.CreateFromJson()` that supports passing in a `JsonSerializerOptions` as a workaround for domaindrivendev#3217.
- Use concrete types as suggested by analyzers.
- Move unshipped APIs to shipped.
- Bump version to 7.3.0.
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 8 changed files in this pull request and generated 1 comment.

Files not reviewed (7)
  • Directory.Build.props: Language not supported
  • src/Swashbuckle.AspNetCore.ReDoc/PublicAPI/PublicAPI.Shipped.txt: Language not supported
  • src/Swashbuckle.AspNetCore.ReDoc/PublicAPI/PublicAPI.Unshipped.txt: Language not supported
  • src/Swashbuckle.AspNetCore.SwaggerGen/PublicAPI/PublicAPI.Shipped.txt: Language not supported
  • src/Swashbuckle.AspNetCore.SwaggerGen/PublicAPI/PublicAPI.Unshipped.txt: Language not supported
  • src/Swashbuckle.AspNetCore.SwaggerUI/PublicAPI/PublicAPI.Shipped.txt: Language not supported
  • src/Swashbuckle.AspNetCore.SwaggerUI/PublicAPI/PublicAPI.Unshipped.txt: Language not supported
Comments suppressed due to low confidence (1)

src/Swashbuckle.AspNetCore.SwaggerGen/SwaggerGenerator/OpenApiAnyFactory.cs:47

  • [nitpick] The error message could be more descriptive. Consider providing additional context or guidance on what went wrong.
throw new System.ArgumentException($"Unsupported value kind {jsonElement.ValueKind}");

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.65%. Comparing base (2fd6b39) to head (4c101bb).
Report is 76 commits behind head on master.

Files with missing lines Patch % Lines
...e.SwaggerGen/SwaggerGenerator/OpenApiAnyFactory.cs 60.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3218   +/-   ##
=======================================
  Coverage   83.65%   83.65%           
=======================================
  Files          76       76           
  Lines        3175     3176    +1     
  Branches      536      536           
=======================================
+ Hits         2656     2657    +1     
  Misses        519      519           
Flag Coverage Δ
Linux 83.65% <60.00%> (+<0.01%) ⬆️
Windows 83.65% <60.00%> (+<0.01%) ⬆️
macOS 83.65% <60.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@martincostello martincostello enabled auto-merge (rebase) January 12, 2025 16:21
@martincostello martincostello merged commit f8d28df into domaindrivendev:master Jan 20, 2025
9 checks passed
@martincostello martincostello deleted the gh-3217 branch January 20, 2025 17:57
This was referenced Jul 31, 2025
This was referenced Sep 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants