-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Allow no match to be found to avoid throwing an exception #3188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the PR - could you update our tests to catch this issue so it doesn't regress in the future please. |
I can do that, yes, but it will be some time before I can start looking at it. |
Test has been added |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3188 +/- ##
=======================================
Coverage 83.65% 83.65%
=======================================
Files 76 76
Lines 3175 3175
Branches 536 536
=======================================
Hits 2656 2656
Misses 519 519
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Thanks for adding the test. |
Pull Request
The issue or feature being addressed
This change fixes #3187
Details on the issue fix or feature implementation
The if indicates this was the intended method call to use.