-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
fix: Pass props to multi targeting #3107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Pass props to multi targeting #3107
Conversation
I guess there's not an easy way to add a test for this, right? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3107 +/- ##
=======================================
Coverage 90.50% 90.50%
=======================================
Files 76 76
Lines 3116 3116
Branches 515 515
=======================================
Hits 2820 2820
Misses 296 296
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
You're right. It’s hard to test as it happens during the |
Pull Request
The issue or feature being addressed
This PR fixes #2706 by passing the defined
Swashbuckle.AspNetCore.props
file to thebuildMultiTargeting
directory, which is used for outer builds (Multi targeting).Details on the issue fix or feature implementation
The props file defines that the
OpenApiGenerateDocumentsOnBuild
property is false by default if it's not set. However, this was not set for multi targeting projects. So the document was generated during the build.