Skip to content

Conversation

@tofi92
Copy link
Contributor

@tofi92 tofi92 commented Aug 16, 2024

Async filters (#2938) could not be registered with the SwaggerGenOptions, so there was no way of using DI with async filters.

I extended the SwaggerGenOptions for all the async filters and also added extension methods similiar to the sync equivalents, so added async filters is now as intuitive as sync filters, e.g. swaggerGenOptions.DocumentAsyncFilter<MyAsyncFilter>().

@tofi92 tofi92 marked this pull request as draft August 20, 2024 06:04
@pinkfloydx33
Copy link

I was very say today when I converted a bunch of filters to be async and then couldn't register them without a bunch of ceremony. I definitely would like this to make it in in some form!

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.43%. Comparing base (e390697) to head (0dc82d9).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3030      +/-   ##
==========================================
+ Coverage   90.18%   90.43%   +0.24%     
==========================================
  Files          74       74              
  Lines        2964     3041      +77     
  Branches      463      487      +24     
==========================================
+ Hits         2673     2750      +77     
  Misses        291      291              
Flag Coverage Δ
Linux 90.43% <100.00%> (+0.24%) ⬆️
Windows 90.43% <100.00%> (+0.24%) ⬆️
macOS 90.43% <100.00%> (+0.24%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello
Copy link
Collaborator

Thanks for your contribution - this looks good.

Could you bump the version to 6.8.0 as we're adding new public API members please? Then this looks good to merge.

<VersionPrefix>6.7.2</VersionPrefix>

@tofi92
Copy link
Contributor Author

tofi92 commented Aug 27, 2024

Hi @martincostello
sorry for the delay, some family problems.

Thanks for your input and for accepting :)

@tofi92 tofi92 marked this pull request as ready for review August 27, 2024 06:02
@martincostello martincostello added this to the v6.8.0 milestone Aug 27, 2024
This was referenced Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants