Skip to content

Add API analysers #3003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2024
Merged

Add API analysers #3003

merged 2 commits into from
Aug 2, 2024

Conversation

@martincostello
Copy link
Collaborator

  • Add public API analysers.
  • Add public API baselines.
  • Enable NuGet package validation.

Resolves #2801.

@martincostello
Enable package validation
62cfe66 
Enable NuGet package validation.
@martincostello
Add public API analysers
3173d11 
- Add public API analysers.
- Add public API baselines.

Resolves domaindrivendev#2801.
@martincostello martincostello added dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code labels Aug 1, 2024
@martincostello martincostello added this to the v6.7.1 milestone Aug 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.61%. Comparing base (5d2fb17) to head (3173d11).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #3003   +/-   ##
=======================================
  Coverage   90.61%   90.61%           
=======================================
  Files          74       74           
  Lines        2962     2962           
  Branches      469      469           
=======================================
  Hits         2684     2684           
  Misses        278      278
Flag Coverage Δ
Linux 81.52% <ø> (-9.10%) ⬇️
Windows 90.61% <ø> (ø)
macOS 90.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martincostello martincostello marked this pull request as ready for review August 1, 2024 11:22
@martincostello martincostello enabled auto-merge (rebase) August 1, 2024 11:22
@martincostello martincostello mentioned this pull request Aug 1, 2024
Merged
mesMess
mesMess approved these changes Aug 2, 2024
View reviewed changes
Copy link
Collaborator

@mesMess mesMess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Analyzer fun
Leveraging the PublicAPI (shipped/unshipped) mechanic
Setting projects to be NuGet(ed) (IsPackable)

@martincostello martincostello merged commit a75f4ad into domaindrivendev:master Aug 2, 2024
@martincostello martincostello deleted the api-analysers branch August 2, 2024 06:30
@renovate renovate bot mentioned this pull request Sep 27, 2024
Merged
1 task
This was referenced Aug 1, 2025
Open
Closed
Closed
Merged
Closed
Closed
Closed
Open
Open
Open
Open
Closed
Open
Open
This was referenced Oct 23, 2025
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Merged
Open
Open
Open
Open
Closed
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mesMess mesMess mesMess approved these changes

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file .NET Pull requests that update .NET code

Projects

None yet

Milestone

v6.7.1

Development

Successfully merging this pull request may close these issues.

Add public API analysers

3 participants

@martincostello @codecov-commenter @mesMess