Skip to content

Fix RequestBodyFilterAnnotation and MultipleFromForm for MinimalApi #2963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Fix RequestBodyFilterAnnotation and MultipleFromForm for MinimalApi #2963

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
dac06e6
Fix RequestBodyFilter for MinimalApi
Jun 24, 2024
4938d8a
Add IntegrationTest using Verify and fix error of several [FromForm] …
Jun 27, 2024
49fcf09
Address PR feedback and ensure an exception is thrown(As before), whe…
Jun 27, 2024
a911f00
Smarter Linq
Jun 27, 2024
85c7d8a
No need of throw exception, it's impossible to reach that code in cas…
Jun 27, 2024
be22e1e
Put attribute on SwaggerVerifyTest to avoid run the test in paralel
Jun 27, 2024
914dd19
Delete blank line
jgarciadelanoceda Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/Swashbuckle.AspNetCore.SwaggerGen/SwaggerGenerator/SwaggerGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,16 +421,18 @@ private OpenApiOperation GenerateOpenApiOperationFromMetadata(ApiDescription api
foreach (var content in requestContentTypes)
{
var requestParameters = apiDescription.ParameterDescriptions.Where(desc => desc.IsFromBody() || desc.IsFromForm());
if (requestParameters.Any())
var countOfParameters = requestParameters.Count();
if (countOfParameters >= 1)
{
_ = requestParameters.SingleOrDefault(desc => desc.IsFromBody());
if (requestParameters.Count() == 1)
if (countOfParameters == 1)
{
var requestParameter = requestParameters.First();
content.Schema = GenerateSchema(
requestParameters.First().ModelMetadata.ModelType,
requestParameter.ModelMetadata.ModelType,
schemaRepository,
requestParameters.First().PropertyInfo(),
requestParameters.First().ParameterInfo());
requestParameter.PropertyInfo(),
requestParameter.ParameterInfo());
}
else
{
Expand Down