Add IncludeXmlCommentsForAssembly convience overload #2909
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2909 +/- ##
==========================================
+ Coverage 89.89% 89.90% +0.01%
==========================================
Files 72 72
Lines 2711 2715 +4
Branches 429 429
==========================================
+ Hits 2437 2441 +4
Misses 274 274
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
test/Swashbuckle.AspNetCore.SwaggerGen.Test/XmlComments/XmlCommentsDocumentFilterTests.cs
Outdated
Show resolved
Hide resolved
|
What about updating some of the tests and the README to use this? code search |
src/Swashbuckle.AspNetCore.SwaggerGen/DependencyInjection/SwaggerGenOptionsExtensions.cs
Outdated
Show resolved
Hide resolved
leotsarev
force-pushed
the
IncludeXmlCommentsForAssembly
branch
from
5ea3d5e to
d66ae91
Compare
Updated tests and README |
martincostello
approved these changes
May 18, 2024
Co-authored-by: Martin Costello <[email protected]>
leotsarev
commented
May 19, 2024
src/Swashbuckle.AspNetCore.SwaggerGen/DependencyInjection/SwaggerGenOptionsExtensions.cs
Show resolved
Hide resolved
|
I don't understand why windows build is failing. Could we restart this to understand if this is some kind of instability? |
WeihanLi
reviewed
Aug 1, 2024
| } | ||
| ); | ||
|
|
||
| var filePath = Path.Combine(System.AppContext.BaseDirectory, "MyApi.xml"); |
There was a problem hiding this comment.
maybe this line could be removed
1 task
This was referenced Aug 1, 2025
Bump Swashbuckle.AspNetCore from 5.6.3 to 9.0.0
timerknight/skills-secure-repository-supply-chain#17
Open
This was referenced Oct 23, 2025
Bump Swashbuckle.AspNetCore from 5.6.3 to 9.0.0
marcuslopes/skills-secure-repository-supply-chain#11
Open
Open
Bump Swashbuckle.AspNetCore from 5.6.3 to 9.0.0
shreeinamdar/skills-secure-repository-supply-chain#8
Open
Open
Bump Swashbuckle.AspNetCore from 5.6.3 to 9.0.0
timo-wilson24/tute-secure-repository-supply-chain#10
Open
Open
Open
Open
Bump Swashbuckle.AspNetCore from 5.6.3 to 9.0.0
Gopikanarra/skills-secure-repository-supply-chain#10
Open
Open
Open
Open
Bump Swashbuckle.AspNetCore from 5.6.3 to 9.0.0
tahershaakir/GHAS-Cert-Dependabot-Module-Excercise#9
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
The issue or feature being addressed
Fixed #2750
Details on the issue fix or feature implementation