Skip to content

Avoid GitHub step summary file write conflicts #2848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
May 6, 2024
Merged

Avoid GitHub step summary file write conflicts #2848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
0986ffb
Avoid GitHub step summary file write conflicts
martincostello May 1, 2024
25ae3b6
Add extra new lines
martincostello May 1, 2024
2237d88
Do not use ReadLinesFromFile
martincostello May 1, 2024
251bf4d
Fix heading
martincostello May 1, 2024
92333a0
Add more new lines
martincostello May 1, 2024
6348351
Try a comment
martincostello May 1, 2024
dd7bbeb
Try something else
martincostello May 1, 2024
c8d9101
Try something else
martincostello May 1, 2024
75641ef
Go back to property
martincostello May 1, 2024
91dac53
Avoid reading if not needed
martincostello May 1, 2024
d77ed2b
Isolate tests that use TestSite
martincostello May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions Directory.Build.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,18 @@
<ReportGeneratorReportTypes Condition=" '$(ReportGeneratorOutputMarkdown)' == 'true' ">$(ReportGeneratorReportTypes);MarkdownSummaryGitHub</ReportGeneratorReportTypes>
<ReportGeneratorTargetDirectory>$([System.IO.Path]::Combine($(ArtifactsPath), 'coverage'))</ReportGeneratorTargetDirectory>
<MergeWith>$([System.IO.Path]::Combine($(ReportGeneratorTargetDirectory), 'coverage.json'))</MergeWith>
<_MarkdownSummaryPrefix>&lt;details&gt;&lt;summary&gt;:chart_with_upwards_trend: &lt;b&gt;$(AssemblyName) Code Coverage report&lt;/b&gt;&lt;/summary&gt;</_MarkdownSummaryPrefix>
<_MarkdownSummarySuffix>&lt;/details&gt;</_MarkdownSummarySuffix>
</PropertyGroup>
<Target Name="GenerateCoverageReports" AfterTargets="GenerateCoverageResultAfterTest" Condition=" '$(CollectCoverage)' == 'true' ">
<ReportGenerator ReportFiles="@(CoverletReport)" ReportTypes="$(ReportGeneratorReportTypes)" Tag="$(Version)" TargetDirectory="$(ReportGeneratorTargetDirectory)" Title="$(AssemblyName)" VerbosityLevel="Warning" />
<Exec Condition=" '$(ReportGeneratorOutputMarkdown)' == 'true' " Command="pwsh -Command %22('$(_MarkdownSummaryPrefix)' + [System.Environment]::NewLine + [System.Environment]::NewLine + (Get-Content $([System.IO.Path]::Combine($(ReportGeneratorTargetDirectory), 'SummaryGithub.md')) | Out-String) + [System.Environment]::NewLine + [System.Environment]::NewLine + '$(_MarkdownSummarySuffix)') >> $(GITHUB_STEP_SUMMARY)%22" />
<PropertyGroup Condition=" '$(ReportGeneratorOutputMarkdown)' == 'true' ">
<_ReportSummaryContent>&lt;details&gt;&lt;summary&gt;:chart_with_upwards_trend: &lt;b&gt;$(AssemblyName) Code Coverage report&lt;/b&gt;&lt;/summary&gt;</_ReportSummaryContent>
<_ReportSummaryContent>$(_ReportSummaryContent)$([System.Environment]::NewLine)</_ReportSummaryContent>
<_ReportSummaryContent>$(_ReportSummaryContent)$([System.Environment]::NewLine)</_ReportSummaryContent>
<_ReportSummaryContent>$(_ReportSummaryContent)$([System.IO.File]::ReadAllText('$([System.IO.Path]::Combine($(ReportGeneratorTargetDirectory), 'SummaryGithub.md'))'))</_ReportSummaryContent>
<_ReportSummaryContent>$(_ReportSummaryContent)$([System.Environment]::NewLine)</_ReportSummaryContent>
<_ReportSummaryContent>$(_ReportSummaryContent)$([System.Environment]::NewLine)</_ReportSummaryContent>
<_ReportSummaryContent>$(_ReportSummaryContent)&lt;/details&gt;</_ReportSummaryContent>
</PropertyGroup>
<WriteLinesToFile Condition=" '$(ReportGeneratorOutputMarkdown)' == 'true' " ContinueOnError="WarnAndContinue" File="$(GITHUB_STEP_SUMMARY)" Lines="$(_ReportSummaryContent)" />
</Target>
</Project>
1 change: 1 addition & 0 deletions test/Swashbuckle.AspNetCore.IntegrationTests/CustomDocumentSerializerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

namespace Swashbuckle.AspNetCore.IntegrationTests
{
[Collection("TestSite")]
public class CustomDocumentSerializerTests
{
[Fact]
Expand Down
1 change: 1 addition & 0 deletions test/Swashbuckle.AspNetCore.IntegrationTests/DocumentProviderTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@

namespace Swashbuckle.AspNetCore.IntegrationTests
{
[Collection("TestSite")]
public class DocumentProviderTests
{
[Theory]
Expand Down
3 changes: 2 additions & 1 deletion test/Swashbuckle.AspNetCore.IntegrationTests/ReDocIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

namespace Swashbuckle.AspNetCore.IntegrationTests
{
[Collection("TestSite")]
public class ReDocIntegrationTests
{
[Fact]
Expand Down Expand Up @@ -58,4 +59,4 @@ public async Task RedocMiddleware_CanBeConfiguredMultipleTimes(string redocUrl,
Assert.Contains(swaggerPath, content);
}
}
}
}
1 change: 1 addition & 0 deletions test/Swashbuckle.AspNetCore.IntegrationTests/SwaggerIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

namespace Swashbuckle.AspNetCore.IntegrationTests
{
[Collection("TestSite")]
public class SwaggerIntegrationTests
{
[Theory]
Expand Down
3 changes: 2 additions & 1 deletion test/Swashbuckle.AspNetCore.IntegrationTests/SwaggerUIIntegrationTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

namespace Swashbuckle.AspNetCore.IntegrationTests
{
[Collection("TestSite")]
public class SwaggerUIIntegrationTests
{
[Theory]
Expand Down Expand Up @@ -88,4 +89,4 @@ public async Task SwaggerUIMiddleware_CanBeConfiguredMultipleTimes(string swagge
}
}
}
}
}