#2765 Allow Filter instance reuse

[remcolam]

Resolves #2765.

[remcolam]

@martincostello I think this might solve this issue... This PR is not complete yet, but I am curious as to whether this approach is the way to go. If so I will add extension methods for all filter types

[remcolam]

Oh, this is about #2765

[martincostello]

This seems a reasonable approach.

[remcolam]

@martincostello I just added that test website, to help investigate, I plan on deleting it. I just needed something to put the example program.cs in from the issue.

This was mostly meant as a POC PR, to see if this would be the approach to solve it. I will now work on a proper solve.

[remcolam]

@martincostello I think I am done with this, pending any new comments

[martincostello]

The build is failing due to the strong naming changes. You might be hitting the complexity I noted here: #2805 (comment)

If you can't easily resolve that, you'll have to create a manual mock and remove NSub.

Also, can you apply the same exact changes as in this commit to your PR please? The CI is failing since GitHub updated the macOS runner: App-vNext/Polly@d7bad63

I could do it myself in a separate PR, but then it would hold things up waiting for someone else to review my changes.

[remcolam]

I configured all projects to be signed, hopefully that should fix the issue... locally the tests run fine now

[martincostello]

I configured all projects to be signed, hopefully that should fix the issue... locally the tests run fine now

Signing any project we ship to NuGet that is not already strong-named is a massively breaking change for anyone using Swashbuckle via netstandard2.0 in a .NET Framework application. We cannot make such a change.

[martincostello]

In fact, breaking or not, at this point this is far too much churn to allow the use of NSub in a few places for your test. Please revert all the signing changes and create a manual mock.