Skip to content

Conversation

@AntiGuideAkquinet
Copy link
Contributor

This is a contiuation of the work done in PR #2710. It closes #2036. If any changes are necessary I'll gladly add them.

blouflashdb and others added 6 commits September 16, 2023 17:00
Without this change the setting will not be set when getting
SchemaGeneratorOptions from DI in SchemaGenerator
Because of the higher precedence of the && operator compared to the ??
operator we need to prioritize ?? manually with brackets.
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.64%. Comparing base (3553751) to head (61760a4).

Files Patch % Lines
...DependencyInjection/SwaggerGenOptionsExtensions.cs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2803      +/-   ##
==========================================
- Coverage   90.67%   90.64%   -0.03%     
==========================================
  Files          74       74              
  Lines        2948     2961      +13     
  Branches      468      469       +1     
==========================================
+ Hits         2673     2684      +11     
- Misses        275      277       +2     
Flag Coverage Δ
Linux 90.64% <85.71%> (-0.03%) ⬇️
Windows 90.64% <85.71%> (-0.03%) ⬇️
macOS 90.64% <85.71%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AntiGuideAkquinet
Copy link
Contributor Author

It seems like #2810 implemented the feature in the meantime. Thanks for the feedback on the code tough.

@martincostello
Copy link
Collaborator

That's a slightly different use case - that's about the required keyword - this change would help for projects not using it, no?

@SimonRask
Copy link
Contributor

@martincostello This could indeed be very useful.

@AntiGuideAkquinet If this could be reopened, it would be appreciated. If you don't have time to address potential comments, I would be happy to help out. :)

@AntiGuideAkquinet
Copy link
Contributor Author

@SimonRask I reopened the PR. Thank you for your help!

@martincostello
Copy link
Collaborator

Thanks for re-opening. If you resolve the merge conflicts I'll take a look.

@SimonRask
Copy link
Contributor

I have (hopefully correctly) resolved the conflicts in my fork. I don't know if it is easier for me to open a new pull request, or if you can pull the changes into your branch. @AntiGuideAkquinet

@AntiGuideAkquinet
Copy link
Contributor Author

@SimonRask Sure! I invited you as a collaborator on the forked repo that the PR is based on. You should be able to pull your changes in. 🙂

@SimonRask
Copy link
Contributor

@martincostello Conflicts should be resolved now :)

This was referenced Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Configure non-nullable types as required

6 participants