💚Move tests to net7 to fix build #2672
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@schnerring Is there a timeline or any blockers on merging this in along with #2671? Really looking forward to being able to use discriminators in .NET 7 without having to add duplicate code. |
|
Since creating the PR, I haven't looked at this again. I guess it would be good timing to sync this with the upcoming .NET 8 changes? But I haven't checked if this is tracked anywhere. |
|
Thanks for contributing - if you'd like to continue with this pull request, please rebase against the default branch to pick up our new CI. From looking at the description only, some parts of this will have been addressed by #2775. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.